port reclaim consumes gigabytes of memory

[mojca (Mojca Miklavec)]

During Building list of distfiles still in use the port reclaim consumes gigabytes of memory (well over 4 GB in my case) and takes forever to complete. Even after Ctrl+C it takes about a minute to actually finish.

Could the implementation be slightly more optimised in that respect?

Actually reclaim could even ask to remove all distfiles before counting them. Once the port is installed the user might no longer need it.

(The period should be changed from two weeks to two months. Why would I need to run reclaim every two weeks? In the past I nearly never did it unless I was really really short on disk space.)

[neverpanic (Clemens Lang)]

Can you try

src/macports1.0/reclaim.tcl

@@ -191 +191 @@
                 set patchfiles {}
             }
 
+            mportclose $mport
+
             foreach distfile [concat $distfiles $patchfiles] {
                 set root_path [file join $root_dist $dist_subdir $distfile]
                 set home_path [file join $home_dist $dist_subdir $distfile]

and see if that helps?

[mojca (Mojca Miklavec)]

Wonderful, thank you very much. Now the memory consumption only goes from 22 to 24 MB rather than consuming gigabytes. Your patch seems to do the expected magic :).

[mojca (Mojca Miklavec)]

In c2df3cc958635f7ac6d0983288723c6ea097b221/macports-base:

Close the portfiles after reading

Close the files in 'port reclaim'
to prevent excessive use of memory.

Closes: #54156

[mojca (Mojca Miklavec)]

Why 2.5.0?

[raimue (Rainer Müller)]

This was already released with MacPorts 2.4.2, see [ca215c1500181ce7942476d439780a9a155499e4/macports-base].

(The 2.4.2 milestone did not exist and I just created it.)