rogue @5.4.4: error: incomplete definition of type 'struct term'

[whmagill]

> sudo port install rogue
--->  Computing dependencies for rogue
--->  Fetching archive for rogue
--->  Attempting to fetch rogue-5.4.4_3.darwin_16.x86_64.tbz2 from https://packages.macports.org/rogue
--->  Attempting to fetch rogue-5.4.4_3.darwin_16.x86_64.tbz2 from http://lil.fr.packages.macports.org/rogue
--->  Attempting to fetch rogue-5.4.4_3.darwin_16.x86_64.tbz2 from http://mse.uk.packages.macports.org/sites/packages.macports.org/rogue
--->  Fetching distfiles for rogue
--->  Attempting to fetch rogue5.4.4-src.tar.gz from https://distfiles.macports.org/rogue
--->  Verifying checksums for rogue
--->  Extracting rogue
--->  Configuring rogue
--->  Building rogue
Error: Failed to build rogue: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_games_rogue/rogue/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets to report a bug.
Error: Processing of port rogue failed

:info:build mdport.c:264:17: error: incomplete definition of type 'struct term'
:info:build     if (cur_term->type.Strings == NULL)
:info:build         ~~~~~~~~^
:info:build /opt/local/include/term.h:710:16: note: forward declaration of 'struct term'
:info:build typedef struct term TERMINAL;}}}

[whmagill]

Log-file

[ryandesign (Ryan Carsten Schmidt)]

I would suspect the recent update of ncurses in [9f2c4a0bfdce59a8d535f3062587f798a6347444/macports-ports].

[kurthindenburg (Kurt Hindenburg)]

I believe ​https://sourceforge.net/projects/advanced-superturbo-rogue-plus/ is the correct site now

[rshuston]

I was able to fix it by doing a quick modification to the modport.c file. Basically I did the following:

Attempt to install rogue...

$ sudo port install rogue

... and wait for installation to fail with the "incomplete definition of type 'struct term'" error.

Edit the mdport.c file as sudo (I use vi but use whatever editor you like):

$ sudo vi /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_games_rogue/rogue/work/rogue5.4.4/mdport.c

Search for the spot where #include <term.h> exits:

#if defined(HAVE_TERM_H)
#include <term.h>
#elif defined(HAVE_NCURSES_TERM_H)
#include <ncurses/term.h>
#endif

and add #define NCURSES_INTERNALS before the #include <term.h> so that you have

#if defined(HAVE_TERM_H)
#define NCURSES_INTERNALS
#include <term.h>
#elif defined(HAVE_NCURSES_TERM_H)
#include <ncurses/term.h>
#endif

Now continue with your installation:

$ sudo port install rogue

Everything should build and install cleanly at this point.

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #55162.

[Polyergic (Shad Sterling)]

How do I get this fix included in the distribution?

[ryandesign (Ryan Carsten Schmidt)]

Replying to rshuston:

I was able to fix it by doing a quick modification to the modport.c file. Basically I did the following:

#define NCURSES_INTERNALS

Thanks, I'll do that for now, then see about updating the port to a newer version later.

[ryandesign (Ryan Carsten Schmidt)]

In dbfaf022b24353c2d1254eee6c961273efc7d0ba/macports-ports:

rogue: Fix build failure with latest ncurses

Closes: #54171