exiv2 @0.26 fails building on 10.5.8 PPC

[udbraumann]

While upgrading exiv2 from 0.25 to 0.26 I was surprised to see this:

...
:info:build [ 54%] Building CXX object src/CMakeFiles/exiv2.dir/actions.cpp.o
:info:build cd /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_exiv2/exiv2/work/exiv2-trunk/src && /usr/bin/g++-4.2  -DEXV_HAVE_DLL -DEXV_HAVE_STDINT_H -DEXV_LOCALEDIR=\"/opt/local/share/locale\" -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_exiv2/exiv2/work/exiv2-trunk/src -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_exiv2/exiv2/work/exiv2-trunk/include -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_exiv2/exiv2/work/exiv2-trunk/include/exiv2 -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_exiv2/exiv2/work/exiv2-trunk -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_exiv2/exiv2/work/exiv2-trunk/xmpsdk/include -I/opt/local/include  -pipe -Os -DNDEBUG -arch ppc -mmacosx-version-min=10.5   -std=c++98 -o CMakeFiles/exiv2.dir/actions.cpp.o -c /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_exiv2/exiv2/work/exiv2-trunk/src/actions.cpp
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_exiv2/exiv2/work/exiv2-trunk/src/actions.cpp:2050: error: ‘PTHREAD_RECURSIVE_MUTEX_INITIALIZER’ was not declared in this scope
:info:build make[2]: *** [src/CMakeFiles/exiv2.dir/actions.cpp.o] Error 1
...

As far as I can guess, this error: ‘PTHREAD_RECURSIVE_MUTEX_INITIALIZER’ was not declared in this scope is a pre-10.7 problem. Any ideas for a workaround?

[ryandesign (Ryan Carsten Schmidt)]

Someone should report this problem to the developers of exiv2 so they can fix it.

[Schamschula (Marius Schamschula)]

Strange, on my iMac G5, running OS X 10.5.8, exiv2 0.26 correctly built and installed.'

Oops. My session to the iMac G5 had been closed, and I was looking at a Yosemite machine...

[Schamschula (Marius Schamschula)]

I've opened a ticket:

​https://github.com/Exiv2/exiv2/issues/9

[clanmills (Robin Mills)]

Thanks for letting me know about this.

I'm a little surprised as I occasionally build on Tiger (10.4) with GCC 4.0. I do this because I have an ancient 2003 PowerBook and it's the only big-endian machine to which I have access! The symbol PTHREAD_RECURSIVE_MUTEX_INITIALIZER is used in actions.cpp to provide a mutex/critical_section to ensure that temporaryPath() returns unique pathnames.

I'll have a look at this on Tiger tomorrow (2017-06-20).

[clanmills (Robin Mills)]

Gentlemen

I reproduced this and fixed this on Tiger. I've also update our release procedure to explicitly mention build/test on Tiger in future. This was a bug that was allowed to escape and could have been detected. Such a lot to do during the release, it's easy to forget something that isn't on the Checklist.

[Schamschula (Marius Schamschula)]

In 14e3faec1f7eb0d32ca4c7478581e425b24b0d8d/macports-ports:

exiv2 0.26: fix build issue for snowleopard and below

Closes: #54335