Opened 7 years ago

Closed 7 years ago

#54376 closed defect (fixed)

math/gsl documentation variant now depends on Sphinx

Reported by: slewsys (Andrew L. Moore) Owned by: dtakahashi
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: Schamschula (Marius Schamschula)
Port: gsl

Description

To build the math/gsl documentation variant, Sphinx is required, along with a recent version of py-sphinx_rtd_theme. Portfile diffs attached:

math_gsl_Portfile.diff - docs variant adds depends_build port:py27-sphinx_rtd_theme

python_py_sphinx-rtd-theme_Portfile.diff - upgrade from version 1.9 => 2.4

Attachments (3)

python_py-sphinx_rtd_theme_Portfile.diff (1.1 KB) - added by slewsys (Andrew L. Moore) 7 years ago.
math_gsl_Portfile.diff (1.1 KB) - added by slewsys (Andrew L. Moore) 7 years ago.
math_gsl Portfile updated per Schamschula comments
Portfile-gsl.diff (3.1 KB) - added by Schamschula (Marius Schamschula) 7 years ago.
Get rid of doc variant

Download all attachments as: .zip

Change History (12)

Changed 7 years ago by slewsys (Andrew L. Moore)

comment:1 Changed 7 years ago by slewsys (Andrew L. Moore)

The previous math_gsl_Portfile.diff fails to recursively copy directories under html. New Portfile.diff attached uses file copy.

comment:2 Changed 7 years ago by Schamschula (Marius Schamschula)

There are a number of problems here:

1) you can't have two depends_build lines, you need to continue using \

2) py-sphinx_rtd_theme can be called from several versions of python that could be installed

3) py-sphinx_rtd_theme has dependencies

4) I'm still seeing issues with the latex documentation: there is no MacPorts fncychap package at the moment

5) The revision on py-sphinx-rtd-theme needs to be reset to 0 (or the revision line needs to be deleted - preferred). The gsl revision needs to be set to 1.

comment:3 Changed 7 years ago by Schamschula (Marius Schamschula)

Cc: Schamschula added

comment:4 Changed 7 years ago by Schamschula (Marius Schamschula)

Owner: set to dtakahashi
Port: gsl added
Status: newassigned

Changed 7 years ago by slewsys (Andrew L. Moore)

Attachment: math_gsl_Portfile.diff added

math_gsl Portfile updated per Schamschula comments

comment:5 in reply to:  2 ; Changed 7 years ago by slewsys (Andrew L. Moore)

Replying to Schamschula:

There are a number of problems here:

1) you can't have two depends_build lines, you need to continue using \

Updated.

2) py-sphinx_rtd_theme can be called from several versions of python that could be installed

It appears this is done via:

depends_build port:py${python.default_version}-sphinx_rtd_theme

Could someone confirm this?

3) py-sphinx_rtd_theme has dependencies

4) I'm still seeing issues with the latex documentation: there is no MacPorts fncychap package at the moment

fncychap is provided by port:texlive-latex-extra, and has been added to gsl Portfile depends_build.

5) The revision on py-sphinx-rtd-theme needs to be reset to 0 (or the revision line needs to be deleted - preferred). The gsl revision needs to be set to 1.

Thank you to Schamschula for flagging these problems! An updated math_gsl_Portfile.diff is attached. -AM

comment:6 in reply to:  5 Changed 7 years ago by Schamschula (Marius Schamschula)

Replying to slewsys:

Replying to Schamschula:

There are a number of problems here:

1) you can't have two depends_build lines, you need to continue using \

Updated.

2) py-sphinx_rtd_theme can be called from several versions of python that could be installed

It appears this is done via:

depends_build port:py${python.default_version}-sphinx_rtd_theme

Could someone confirm this?

I don't think using the python PortGroup works. I have a similar issue with the nghttp2 port. I tried a different approach in this case:

I added

                    bin:sphinx-build:py27-sphinx \
                    path:Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/sphinx_rtd_theme:py27-sphinx_rtd_theme \
                    path:Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/typing.py:py27-typing \
                    path:Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/sphinxcontrib/websupport:py27-sphinxcontrib-websupport

to depends_build. This checks for any version of the required python ports, but installs the python 2.7 version as a fall-back.

3) py-sphinx_rtd_theme has dependencies

4) I'm still seeing issues with the latex documentation: there is no MacPorts fncychap package at the moment

fncychap is provided by port:texlive-latex-extra, and has been added to gsl Portfile depends_build.

5) The revision on py-sphinx-rtd-theme needs to be reset to 0 (or the revision line needs to be deleted - preferred). The gsl revision needs to be set to 1.

Thank you to Schamschula for flagging these problems! An updated math_gsl_Portfile.diff is attached. -AM

comment:7 Changed 7 years ago by Schamschula (Marius Schamschula)

I just created new variants for Python 2.7, 3.5 and 3.6 versions of Sphinx. One of those is required to build the documentation.

Changed 7 years ago by Schamschula (Marius Schamschula)

Attachment: Portfile-gsl.diff added

Get rid of doc variant

comment:8 Changed 7 years ago by Schamschula (Marius Schamschula)

This version gets rid of the +doc variant that cannot be called w/o calling a +doc_pythonXX variant.

comment:9 Changed 7 years ago by Schamschula (Marius Schamschula)

Resolution: fixed
Status: assignedclosed

In 48f5509e5bb503282f91f849cc36c2ad83205a27/macports-ports:

gsl: replace doc variant with doc_pythonXX variants

Closes: #54376

Note: See TracTickets for help on using tickets.