gnome-chess-3.22.2 fails to build with recent tools / valac

[jeremyhu (Jeremy Huddleston Sequoia)]

gnome-chess-3.22.2 fails to build due to recent changes (I haven’t narrowed down if it’s a toolchain change or a dependency change). It’s failing with:

gnome-chess.c:6522:41: error: a parameter list without types is only allowed in a function definition
        G_MODULE_EXPORT clock_type_changed_cb (_tmp18_, self);
                                               ^
gnome-chess.c:6607:65: error: expected ')'
        G_MODULE_EXPORT timer_increment_units_changed_cb ((GtkWidget*) _tmp23_, self);
                                                                       ^
gnome-chess.c:6607:51: note: to match this '('
        G_MODULE_EXPORT timer_increment_units_changed_cb ((GtkWidget*) _tmp23_, self);
                                                         ^
gnome-chess.c:6607:18: error: conflicting types for 'timer_increment_units_changed_cb'
        G_MODULE_EXPORT timer_increment_units_changed_cb ((GtkWidget*) _tmp23_, self);
                        ^
gnome-chess.c:425:22: note: previous declaration is here
void G_MODULE_EXPORT timer_increment_units_changed_cb (GtkWidget* widget, ChessApplication* self);
                     ^
gnome-chess.c:7309:51: error: expected identifier
        G_MODULE_EXPORT preferences_response_cb (_tmp0_, (gint) GTK_RESPONSE_CANCEL, self);
                                                         ^
gnome-chess.c:7309:18: error: conflicting types for 'preferences_response_cb'
        G_MODULE_EXPORT preferences_response_cb (_tmp0_, (gint) GTK_RESPONSE_CANCEL, self);
                        ^
gnome-chess.c:7293:22: note: previous definition is here
void G_MODULE_EXPORT preferences_response_cb (GtkWidget* widget, gint response_id, ChessApplication* self) {
                     ^
5 errors generated.

As gnome-chess.c is generated by valac, and gnome-chess is using the packaged version of the file instead of regenerating it with valac, I decided to force its recreation by updating the timestamp on *.vala. However, the subsequent make fails with a valac error:

gnome-chess.vala:100.5-107.6: warning: the modifier `static' is not applicable to constants
gnome-chess.vala:1147.23-1147.26: error: Argument 1: Cannot pass value to reference or output parameter
        model.remove (iter);
                      ^^^^

[jeremyhu (Jeremy Huddleston Sequoia)]

The latter seems addressed by:

​https://github.com/GNOME/gnome-chess/commit/1b27c4b8a90fdd20748a323671270063b55c9a49 ​https://github.com/GNOME/gnome-chess/commit/50ec9dc4c8ee3ac3a372cb9a93f37f46fa202df9

[jeremyhu (Jeremy Huddleston Sequoia)]

I revbumped the port to 3.24.1, and it “just worked” … mind if I push that?

[jeremyhu (Jeremy Huddleston Sequoia)]

In b9567ce9c0ae0f1b4198febb702620f7f38642c1/macports-ports:

gnome-chess: Update to 3.24.1

Closes: #54381

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@…>