#54478 closed update (fixed)
jsch update to 0.1.54
Reported by: | chicagotripp (Altoine Barker) | Owned by: | raimue (Rainer Müller) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | haspatch | Cc: | |
Port: | jsch |
Description
I had did a fresh install and reinstalled the port jsch-0.1.53
and found that it failed on install. The build needed a change as Javac wasn't supporting builds prior to target
or source
1.6
. I checked for an update and found that the file still failed on the same error. I inputed the change to support 1.7
for both target and source in the build.xml file and the port successfully installed. I cleaned up the port from the jsch-0.1.53
utilizing the awesome port lint --nitpick
command.
Attachments (2)
Change History (8)
Changed 7 years ago by chicagotripp (Altoine Barker)
Attachment: | Portfile.jsch.diff added |
---|
Changed 7 years ago by chicagotripp (Altoine Barker)
Attachment: | patch-build.xml.diff added |
---|
Patch file for jsch-0.1.54.
comment:1 follow-up: 2 Changed 7 years ago by mf2k (Frank Schima)
Thanks! It is hard to evaluate your patch because you have mixed whitespace changes with functional ones. We prefer that you submit 2 patches, separating the functional changes from the whitespace ones.
comment:2 Changed 7 years ago by chicagotripp (Altoine Barker)
Thank you for the feedback. I apologize and I will make sure to do that in the future. Do you need me to correct and redo my submissions with your suggestions?
Replying to mf2k:
Thanks! It is hard to evaluate your patch because you have mixed whitespace changes with functional ones. We prefer that you submit 2 patches, separating the functional changes from the whitespace ones.
comment:3 Changed 7 years ago by chicagotripp (Altoine Barker)
I basically did a version bump to 0.1.54, updated the checksums for the new version, made the correction to the build.xml file to allow it to complete building, and then included a patch.
comment:4 Changed 7 years ago by raimue (Rainer Müller)
comment:5 Changed 7 years ago by raimue (Rainer Müller)
Owner: | set to raimue |
---|---|
Resolution: | → fixed |
Status: | new → closed |
comment:6 Changed 7 years ago by raimue (Rainer Müller)
I separated the whitespace changes and recreated your changes. Thank you for your contribution. For future updates as a maintainer, just file Trac tickets with a unified diff or open a pull request on GitHub.
Portfile unified diff of update to version jsch-0.1.54