Opened 7 years ago
Closed 7 years ago
#54542 closed defect (duplicate)
gtk3 @3.22.17: error: expected '>'
Reported by: | Gord-Butler | Owned by: | dbevans (David B. Evans) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.4.1 |
Keywords: | mavericks | Cc: | jjstickel (Jonathan Stickel), poetnerd (Bill Cattey), mfuhrer |
Port: | gtk3 |
Description
Having trouble upgrading gtk3 on Mavericks. The upgrade quits at the build stage. Log file included.
Attachments (1)
Change History (12)
Changed 7 years ago by Gord-Butler
comment:1 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | dbevans removed |
---|---|
Keywords: | gtk3 10.9 removed |
Owner: | set to dbevans |
Status: | new → assigned |
Summary: | gtk3 3.22.17 fails to build on Mavericks 10.9.5 → gtk3 @3.22.17: error: expected '>' |
What versions of Xcode, command line tools, and clang do you have installed?
Looks similar to #54518.
comment:2 Changed 7 years ago by kencu (Ken)
I just worked through this on 10.8. It only happens with the +quartz build. I don't have patches as yet, but here's what I did to build it.
fixing gtk3 +quartz: in work/gtk+-3.22.17/gtk: in gtkfilefilterprivate.h and in gtkfilefilter.c Change NSArray<NSString *> * -to- NSArray * ============ in work/gtk+-3.22.17/gtk in gtkfilechoosernativequartz.c Make the following replacements: NSMutableArray<NSArray<NSString *> *> * -to- NSMutableArray * NSMutableArray<NSString *> * -to- NSMutableArray * NSArray<NSString *> * -to- NSArray * NSMutableArray<NSArray *> -to- NSMutableArray NSMutableArray<NSString *> -to- NSMutableArray
comment:3 Changed 7 years ago by kencu (Ken)
See <https://github.com/GNOME/gtk/commits/master/gtk/gtkfilechoosernativequartz.c>
It's a new enhancement; perhaps upstream would agree to #ifdef some minor changes in to support older sdks. Otherwise, the changes I made took about 10 minutes to do, so it's an easy patch once I or someone gets around to it.
comment:4 Changed 7 years ago by jjstickel (Jonathan Stickel)
Cc: | jjstickel added |
---|
comment:5 Changed 7 years ago by poetnerd (Bill Cattey)
Cc: | poetnerd added |
---|
comment:6 Changed 7 years ago by poetnerd (Bill Cattey)
Hi Ken,
Thanks for moving this one forward. Your list of replacements is good, but can't be treated as an exact substitution because line 465 looks like this:
data->filters = [NSMutableArray<NSArray<NSString *> *> arrayWithCapacity:n_filters];
We have to change that to:
data->filters = [NSMutableArray arrayWithCapacity:n_filters];
comment:7 follow-up: 8 Changed 7 years ago by kencu (Ken)
Don't forget that a helpful patch has been made already to ease the pain :)
comment:8 Changed 7 years ago by jjstickel (Jonathan Stickel)
comment:10 Changed 7 years ago by mfuhrer
Cc: | mfuhrer added |
---|
comment:11 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → duplicate |
---|---|
Status: | assigned → closed |
Log file of port build