Opened 7 years ago

Closed 5 years ago

Last modified 5 years ago

#54566 closed submission (wontfix)

ipfs @0.4.10 : global, versioned, peer-to-peer filesystem

Reported by: 1-61803 Owned by:
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: raimue (Rainer Müller)
Port: ipfs

Description

Attachments (2)

Portfile (3.4 KB) - added by 1-61803 7 years ago.
Portfile.2 (2.2 KB) - added by 1-61803 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by 1-61803

Attachment: Portfile added

comment:1 Changed 7 years ago by raimue (Rainer Müller)

As discussed on macports-dev, you cannot use $user_home. The startupitem probably needs to be fixed to store its data in ${prefix}/var/ipfs or similar. If I read the Portfile correctly, this will currently even run the daemon as root, which should be avoided. Create a separate user with add_user and specify to use that in the LaunchDaemon.

Actually, upstream does not install this as a LaunchDaemon (system-wide), but as a LaunchAgent (per-user). This might make more sense, but I do not know what this software is supposed to do.

In any case, the number of reinplace statements make it look like it would be easier to maintain a custom .plist file (or create one using startupitem.*) instead of editing all of the key/value pairs with regular expressions.

The installation of the startupitem should also respect startupitem_install as set in macports.conf.

The bash-completion file should be installed as ${prefix}/share/bash-completion/completions/ipfs in order to load it automatically on demand. The note can then be removed as no user interaction will be required.

Is the go port really required at runtime? I thought Go would just compile and link a binary. If so, it should be moved to depends_build.

comment:2 Changed 7 years ago by raimue (Rainer Müller)

Cc: raimue added

Changed 7 years ago by 1-61803

Attachment: Portfile.2 added

comment:3 Changed 7 years ago by 1-61803

I left the startup item for the user to install, corrected the go dependency and left the autocompletion as it was — for lack of feedback in the dev list to the points raised.

comment:4 Changed 5 years ago by raimue (Rainer Müller)

Resolution: wontfix
Status: newclosed

comment:5 in reply to:  4 Changed 5 years ago by 1-61803

Replying to raimue:

ipfs exists as a port, https://ports.macports.org/port/ipfs

Hmm...it existed already. But yeah, 'wontfix'.

Note: See TracTickets for help on using tickets.