Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#54815 closed enhancement (fixed)

Using GitHub portgroup for port 'boxes'

Reported by: StefKKK Owned by: mf2k (Frank Schima)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: boxes

Description

Switched to using github portgroup for boxes

Attachments (3)

boxes-github.diff​ (3.6 KB) - added by StefKKK 7 years ago.
main.log​ (86.3 KB) - added by StefKKK 7 years ago.
boxes-github-proposed-change.diff​ (3.3 KB) - added by StefKKK 7 years ago.

Download all attachments as: .zip

Change History (10)

Changed 7 years ago by StefKKK

Attachment: boxes-github.diff​ added

comment:1 Changed 7 years ago by mf2k (Frank Schima)

Keywords: haspatch added; boxes portgroup github removed

Thanks for the fixes. But please do not open a new ticket. Attaching it to the existing ticket #54811 is preferred.

some comments:

  • Change your GitHub.setup as follows and remove the extract.suffix and distfiles lines: 
    github.setup            ascii-boxes boxes 1.2 v

comment:2 Changed 7 years ago by mf2k (Frank Schima)

Please stick with this ticket! :)

Changed 7 years ago by StefKKK

Attachment: main.log​ added

comment:3 Changed 7 years ago by StefKKK

Sorry!

However, now it can't find the archive anymore (see main.log)

comment:4 Changed 7 years ago by mf2k (Frank Schima)

Please attach the diff of your updated Portfile. Based on the archive name it is trying to fetch - boxes-1.2.tar.gz - you are not using the correct GitHub.setup line that I suggested.

comment:5 Changed 7 years ago by StefKKK

You're right, I edited the wrong file. Please find enclosed the patch with your proposed changes

Changed 7 years ago by StefKKK

Attachment: boxes-github-proposed-change.diff​ added

comment:6 Changed 7 years ago by mf2k (Frank Schima)

Owner: set to mf2k
Resolution: → fixed
Status: new → closed

In 0b947f0027f4eec5655bc8dd82b42761fb420351/macports-ports:

boxes: Update to version 1.2. Add maintainer. Use github portgroup.

Closes: #54815

comment:7 Changed 7 years ago by mf2k (Frank Schima)

It still was not correct. But I fixed it and committed my changes. Thanks for stepping up as maintainer!

Last edited 7 years ago by mf2k (Frank Schima) (previous) (diff)
Note: See TracTickets for help on using tickets.