Opened 7 years ago
Closed 7 years ago
#54868 closed defect (fixed)
py-ipython: missing dependencies on py-typing and py-pathlib2 for some python versions
Reported by: | Ionic (Mihai Moldovan) | Owned by: | lpsinger (Leo Singer) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | haspatch | Cc: | seanfarley (Sean Farley), stromnov (Andrey Stromnov) |
Port: | py-ipython |
Description
Following error occurred when installing py34-ipykernel
(as a dependency of something else):
:info:build Executing: cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_macports.rsync.ionic.de_release_ports_python_py-ipykernel/py34-ipykernel/work/ipykernel-4.6.1" && /opt/local/Library/Frameworks/Python.framework/Versions/3.4/bin/python3.4 setup.py --no-user-cfg build :debug:build system: cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_macports.rsync.ionic.de_release_ports_python_py-ipykernel/py34-ipykernel/work/ipykernel-4.6.1" && /opt/local/Library/Frameworks/Python.framework/Versions/3.4/bin/python3.4 setup.py --no-user-cfg build :info:build Traceback (most recent call last): :info:build File "setup.py", line 91, in <module> :info:build from ipykernel.kernelspec import write_kernel_spec, make_ipkernel_cmd, KERNEL_NAME :info:build File "/opt/local/var/macports/build/_opt_local_var_macports_sources_macports.rsync.ionic.de_release_ports_python_py-ipykernel/py34-ipykernel/work/ipykernel-4.6.1/ipykernel/__init__.py", line 2, in <module> :info:build from .connect import * :info:build File "/opt/local/var/macports/build/_opt_local_var_macports_sources_macports.rsync.ionic.de_release_ports_python_py-ipykernel/py34-ipykernel/work/ipykernel-4.6.1/ipykernel/connect.py", line 13, in <module> :info:build from IPython.core.profiledir import ProfileDir :info:build File "/opt/local/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/IPython/__init__.py", line 55, in <module> :info:build from .terminal.embed import embed :info:build File "/opt/local/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/IPython/terminal/embed.py", line 16, in <module> :info:build from IPython.terminal.interactiveshell import TerminalInteractiveShell :info:build File "/opt/local/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/IPython/terminal/interactiveshell.py", line 32, in <module> :info:build from .debugger import TerminalPdb, Pdb :info:build File "/opt/local/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/IPython/terminal/debugger.py", line 6, in <module> :info:build from IPython.core.completer import IPCompleter :info:build File "/opt/local/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/IPython/core/completer.py", line 132, in <module> :info:build from typing import Iterator, List, Tuple, Iterable, Union :info:build ImportError: No module named 'typing' :info:build Command failed: cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_macports.rsync.ionic.de_release_ports_python_py-ipykernel/py34-ipykernel/work/ipykernel-4.6.1" && /opt/local/Library/Frameworks/Python.framework/Versions/3.4/bin/python3.4 setup.py --no-user-cfg build :info:build Exit code: 1
Turns out: that's right.
According to ipython's setup.py file, we need to depend upon py-pathlib2
for python 3.3 and py-typing
for python 3.4 and below.
I'll attach a patch for you to review. If you're okay with it, I can also commit it.
Attachments (1)
Change History (4)
Changed 7 years ago by Ionic (Mihai Moldovan)
Attachment: | py-ipython.patch added |
---|
comment:1 Changed 7 years ago by Andrew Stromnov <stromnov@…>
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:2 Changed 7 years ago by Ionic (Mihai Moldovan)
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Thanks for applying the fix.
I have to reopen this ticket, since we do need the revbump, though, since py-ipython
installs fine without this dependency (because something doesn't seem to be checking the extra dependencies), but py-ipykernel
(and maybe other dependencies) will fail to build.
comment:3 Changed 7 years ago by Andrew Stromnov <stromnov@…>
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Note: See
TracTickets for help on using
tickets.
Proposed patch for
py-ipython
.