optipng @0.7.6: error: no member named 'st_atim' in 'struct stat'

[fracai]

osys.c:515:25: error: no member named 'st_atim' in 'struct stat'
        times[0] = sbuf.st_atim;
                   ~~~~ ^
osys.c:516:25: error: no member named 'st_mtim' in 'struct stat'
        times[1] = sbuf.st_mtim;
                   ~~~~ ^
2 errors generated.
make[1]: *** [osys.o] Error 1

Looks like a similar issue occurred previously: ​https://sourceforge.net/p/optipng/bugs/47/

[fracai]

build log

[kencu (Ken)]

Looks identical or closely related to 54774.

[ryandesign (Ryan Carsten Schmidt)]

The bug has already been ​reported to the developers. I'll await their fix.

[phriedrich]

Is there an option in MacPorts to patch the source for a certain version of macOS?

Replacing lines 515 and 516 in src/optipng/osys.c with

        #if defined OSYS_DARWIN
             times[0] = sbuf.st_atimespec;
             times[1] = sbuf.st_mtimespec;
         #else
             times[0] = sbuf.st_atim;
             times[1] = sbuf.st_mtim;
         #endif

works for me, but I haven't tested this on older versions of OS X/macOS.

[ryandesign (Ryan Carsten Schmidt)]

Replying to phriedrich:

Is there an option in MacPorts to patch the source for a certain version of macOS?

Of course. For example, to add a patch only on darwin 17 (macOS High Sierra) and later:

if {${os.platform} eq "darwin" && ${os.major} >= 17} {
    patchfiles-append something.patch
}

But older OS versions shouldn't see this code at all since they don't have the requisite OS functions, so a conditional patch shouldn't be needed.

[phriedrich]

Theoretically we also wouldn't need the check for OSYS_DARWIN here, since the patch is only applied in MacPorts.

So a patch like this would be enough:

diff -Naur optipng-0.7.6/src/optipng/osys.c optipng-0.7.6_hs/src/optipng/osys.c
--- optipng-0.7.6/src/optipng/osys.c  2014-10-05 05:51:00.000000000 +0200
+++ optipng-0.7.6_hs/src/optipng/osys.c 2017-12-09 18:31:59.000000000 +0100
@@ -512,8 +512,8 @@
     {
         struct timespec times[2];

-        times[0] = sbuf.st_atim;
-        times[1] = sbuf.st_mtim;
+        times[0] = sbuf.st_atimespec;
+        times[1] = sbuf.st_mtimespec;
         if (utimensat(AT_FDCWD, dest_path, times, 0) != 0)
             result = -1;
     }

Is this the right format?

[ryandesign (Ryan Carsten Schmidt)]

I am working on the patch now. I will keep the operating system check, since MacPorts can theoretically be installed on non-Mac systems.

[phriedrich]

Thank you!

[ryandesign (Ryan Carsten Schmidt)]

In f69d413bbcc4ed122933757146168c5103e6039f/macports-ports:

optipng: Fix build on High Sierra

Closes: #54948