fish @2.6.0: Bus error on launch

[snigel]

Fish 2.6.0 compiles but cannot run.

iBookG4:~ snigel$ fish
Bus error

[mf2k (Frank Schima)]

In the future, please use WikiFormatting.

[kencu (Ken)]

I can look into this.

[kencu (Ken)]

Process:         fish [40904]
Path:            /opt/local/bin/fish
Identifier:      fish
Version:         ??? (???)
Code Type:       PPC (Native)
Parent Process:  bash [32295]

Date/Time:       2017-10-02 12:40:01.147 -0700
OS Version:      Mac OS X 10.5.8 (9L31a)
Report Version:  6
Anonymous UUID:  4F6A742C-6D8E-40B3-B0E3-1961C4592BC9

Exception Type:  EXC_BAD_ACCESS (SIGBUS)
Exception Codes: KERN_PROTECTION_FAILURE at 0x0000000000000000
Crashed Thread:  0

Thread 0 Crashed:
0   libSystem.B.dylib             	0x900403d0 realpath$DARWIN_EXTSN + 172
1   fish                          	0x000711b4 wrealpath(std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > const&, wchar_t*) + 496
2   fish                          	0x000334a0 __ZL25expand_stage_home_and_pidRKSbIwSt11char_traitsIwESaIwEEPSt6vectorI12completion_tSaIS6_EEiPS5_I13parse_error_tSaISA_EE + 64
3   fish                          	0x00034da0 expand_string(std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > const&, std::vector<completion_t, std::allocator<completion_t> >*, int, std::vector<parse_error_t, std::allocator<parse_error_t> >*) + 520
4   fish                          	0x0004d780 parse_execution_context_t::determine_arguments(parse_node_t const&, std::vector<std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> >, std::allocator<std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > > >*, parse_execution_context_t::globspec_t) + 336
5   fish                          	0x0004e25c parse_execution_context_t::populate_plain_process(job_t*, process_t*, parse_node_t const&) + 672
6   fish                          	0x0004e574 parse_execution_context_t::populate_job_process(job_t*, process_t*, parse_node_t const&) + 324
7   fish                          	0x0004e7b0 parse_execution_context_t::populate_job_from_job_node(job_t*, parse_node_t const&, block_t const*) + 248
8   fish                          	0x0004ee58 parse_execution_context_t::run_1_job(parse_node_t const&, block_t const*) + 1144
9   fish                          	0x0004f0ec parse_execution_context_t::run_job_list(parse_node_t const&, block_t const*) + 176
10  fish                          	0x0004fed0 parse_execution_context_t::eval_node_at_offset(unsigned int, block_t const*, io_chain_t const&) + 616
11  fish                          	0x0005875c parser_t::eval_block_node(unsigned int, io_chain_t const&, block_type_t) + 260
12  fish                          	0x000595e8 parser_t::eval(std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > const&, io_chain_t const&, block_type_t, parse_node_tree_t) + 288
13  fish                          	0x000662c4 __ZL7read_niiRK10io_chain_t + 572
14  fish                          	0x0006669c reader_read(int, io_chain_t const&) + 720
15  fish                          	0x0000bc68 __ZL14builtin_sourceR8parser_tR12io_streams_tPPw + 420
16  fish                          	0x00008d28 builtin_run(parser_t&, wchar_t const* const*, io_streams_t&) + 344
17  fish                          	0x00030884 exec_job(parser_t&, job_t*) + 3444
18  fish                          	0x0004efc8 parse_execution_context_t::run_1_job(parse_node_t const&, block_t const*) + 1512
19  fish                          	0x0004f0ec parse_execution_context_t::run_job_list(parse_node_t const&, block_t const*) + 176
20  fish                          	0x0004fed0 parse_execution_context_t::eval_node_at_offset(unsigned int, block_t const*, io_chain_t const&) + 616
21  fish                          	0x0005875c parser_t::eval_block_node(unsigned int, io_chain_t const&, block_type_t) + 260
22  fish                          	0x000595e8 parser_t::eval(std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > const&, io_chain_t const&, block_type_t, parse_node_tree_t) + 288
23  fish                          	0x00059764 parser_t::eval(std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > const&, io_chain_t const&, block_type_t) + 276
24  fish                          	0x00072590 __ZL26source_config_in_directoryRKSbIwSt11char_traitsIwESaIwEE + 320
25  fish                          	0x0007400c main + 1056
26  fish                          	0x00003dfc start + 64

[kencu (Ken)]

Upstream issue <​https://github.com/fish-shell/fish-shell/issues/4433>.

[kencu (Ken)]

long and short of it that this may not be fixed any time soon on 10.5 PPC. For now, you'll have to roll back to the last version.

To do that, sudo port activate fish, and in the menu that comes up, select the previous version you had installed.

If you have no previous version installed, then that's a slightly larger headache.

I'll look at making a rollback in the portfile for PPC if this doesn't resolve itself soonish.

[kencu (Ken)]

Upstream came up with a patch quickly, and when applied it appears to resolve this issue. Looks like it is more to do with Leopard and earlier than it has to do with PowerPC. I have the patch applied, and fish is working correctly on 10.5 PPC. I'll upload this for now, and presumably a new version of fish will come out at some point incorporating this fix.

[kencu (Ken)]

In bda78c75fc1fe33d3e40edebb07e4420d7aa93ce/macports-ports:

fish: fix build on Leopard and earlier

closes: #54974