Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#55106 closed enhancement (fixed)

dblatex add a -latex variant

Reported by: nortcele Owned by: neverpanic (Clemens Lang)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: mojca (Mojca Miklavec)
Port: dblatex

Description

Here is a patch to add a -latex variant to dblatex. The aim is to permit to use dblatex with a texlive installation not provided by MacPorts.

Could this patch be reviewed?

Attachments (2)

dblatex-0.3.10-latex.diff (2.7 KB) - added by nortcele 7 years ago.
Patch to add a -latex variant
dblatex-0.3.10-mactex.diff (3.8 KB) - added by nortcele 7 years ago.
Patch to add a +mactex variant

Download all attachments as: .zip

Change History (14)

Changed 7 years ago by nortcele

Attachment: dblatex-0.3.10-latex.diff added

Patch to add a -latex variant

comment:1 Changed 7 years ago by Schamschula (Marius Schamschula)

Cc: neverpanic removed
Owner: set to neverpanic
Status: newassigned

comment:2 Changed 7 years ago by raimue (Rainer Müller)

Other ports (LaTeXML, auctex, kde4-kile) already provide a +mactex variant that allows to use MacTeX instead of the texlive ports. Is your texlive installation completely custom? If your use case is also MacTeX, we might want to follow that naming scheme for consistency.

You added bin:mtxrun:... as a dependency, however proc dblatex.mktexlsr only uses it if -latex is selected. Was that intentional? Note texlive.mktexlsr runs mtxrun if installed, so this functionality would now be missing. I would drop the dependency on mtxrun and write the proc like this:

proc dblatex.mktexlsr {} {
    if {[variant_isset latex]} {
        system "mktexlsr"
        system "if command -v mtxrun >/dev/null 2>&1; then mtxrun --generate; fi"
    } else {
        texlive.mktexlsr
    }
}

Why does post-deactivate need to delete files? MacPorts removes all files it installed, so what would be left? If this was in case the value of TEXMFLOCAL changed between activate and deactivate, I do not think we can handle this. In the worst case, it could have unintended side effects.

comment:3 Changed 7 years ago by mojca (Mojca Miklavec)

Why do you need mtxrun for a package that's only usable in LaTeX? Or can it in fact be used by ConTeXt?

comment:4 Changed 7 years ago by mojca (Mojca Miklavec)

Cc: mojca added

comment:5 Changed 7 years ago by mojca (Mojca Miklavec)

I don't know why but files installed in the MacTeX hierarchy are not deleted when I uninstall dbatex and the next installation fails because files are allready here.

This usually means that DESTDIR is missing in the path for the TeX support files.

comment:6 Changed 7 years ago by nortcele

I added a new patch with a +mactex variant.

comment:7 Changed 7 years ago by nerdling (Jeremy Lavergne)

When glancing through the diff it looked good to me, however I'm not currently in a position to test it.

comment:8 Changed 7 years ago by nortcele

With the new patch, files installed are correctly uninstalled now.

I tested the installation, dblatex and uninstallation on macOS 10.13.1 with and without the +maxtex variant and on 10.9.5 without +mactex variant.

Are there other things I should do to make the patch acceptable?

comment:9 Changed 7 years ago by mojca (Mojca Miklavec)

Keywords: haspatch added

Changed 7 years ago by nortcele

Attachment: dblatex-0.3.10-mactex.diff added

Patch to add a +mactex variant

comment:10 Changed 7 years ago by nortcele

Update patch (modifications suggested by mf2k_mp and neverpanic) :

  • move description specific to mactex variant from general description to variant description
  • correct an alignment typo
Last edited 7 years ago by nortcele (previous) (diff)

comment:11 Changed 7 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: assignedclosed

In 9d1d297ed317aa861fc958a4aae4e9713ca0b2e7/macports-ports:

dblatex: Add variant to support MacTeX

Closes: #55106

comment:12 Changed 7 years ago by nortcele

Thank you.

Note: See TracTickets for help on using tickets.