dblatex add a -latex variant

[nortcele]

Here is a patch to add a -latex variant to dblatex. The aim is to permit to use dblatex with a texlive installation not provided by MacPorts.

Could this patch be reviewed?

[nortcele]

Patch to add a -latex variant

[raimue (Rainer Müller)]

Other ports (LaTeXML, auctex, kde4-kile) already provide a +mactex variant that allows to use ​MacTeX instead of the texlive ports. Is your texlive installation completely custom? If your use case is also MacTeX, we might want to follow that naming scheme for consistency.

You added bin:mtxrun:... as a dependency, however proc dblatex.mktexlsr only uses it if -latex is selected. Was that intentional? Note texlive.mktexlsr runs mtxrun if installed, so this functionality would now be missing. I would drop the dependency on mtxrun and write the proc like this:

proc dblatex.mktexlsr {} {
    if {[variant_isset latex]} {
        system "mktexlsr"
        system "if command -v mtxrun >/dev/null 2>&1; then mtxrun --generate; fi"
    } else {
        texlive.mktexlsr
    }
}

Why does post-deactivate need to delete files? MacPorts removes all files it installed, so what would be left? If this was in case the value of TEXMFLOCAL changed between activate and deactivate, I do not think we can handle this. In the worst case, it could have unintended side effects.

[mojca (Mojca Miklavec)]

Why do you need mtxrun for a package that's only usable in LaTeX? Or can it in fact be used by ConTeXt?

[mojca (Mojca Miklavec)]

I don't know why but files installed in the MacTeX hierarchy are not deleted when I uninstall dbatex and the next installation fails because files are allready here.

This usually means that DESTDIR is missing in the path for the TeX support files.

[nortcele]

I added a new patch with a +mactex variant.

[nerdling (Jeremy Lavergne)]

When glancing through the diff it looked good to me, however I'm not currently in a position to test it.

[nortcele]

With the new patch, files installed are correctly uninstalled now.

I tested the installation, dblatex and uninstallation on macOS 10.13.1 with and without the +maxtex variant and on 10.9.5 without +mactex variant.

Are there other things I should do to make the patch acceptable?

[nortcele]

Patch to add a +mactex variant

[nortcele]

Update patch (modifications suggested by mf2k_mp and neverpanic) :

• move description specific to mactex variant from general description to variant description
• correct an alignment typo

[neverpanic (Clemens Lang)]

In 9d1d297ed317aa861fc958a4aae4e9713ca0b2e7/macports-ports:

dblatex: Add variant to support MacTeX

Closes: #55106

[nortcele]

Thank you.