Opened 7 years ago

Closed 7 years ago

#55165 closed defect (fixed)

harfbuzz @1.6.3: cc1plus: error: unrecognized command line option "-std=c++11"

Reported by: kencu (Ken) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: Schamschula (Marius Schamschula), MarcusCalhoun-Lopez (Marcus Calhoun-Lopez), ballapete (Peter "Pete" Dyballa)
Port: harfbuzz

Description

<https://build.macports.org/builders/ports-10.5_ppc_legacy-builder/builds/43346/steps/install-port/logs/stdio>

will need PortGroup cxx11 1.1, which is verified to fix the build on 10.5 PPC.

libtool: compile:  /usr/bin/g++-4.2 -DHAVE_CONFIG_H -I. -I.. -pthread -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include/freetype2 -I./hb-ucdn -I/opt/local/include -pipe -Os -arch ppc -std=c++11 -fno-rtti -fno-exceptions -Wcast-align -fvisibility-inlines-hidden -MT libharfbuzz_la-hb-blob.lo -MD -MP -MF .deps/libharfbuzz_la-hb-blob.Tpo -c hb-blob.cc  -fno-common -DPIC -o .libs/libharfbuzz_la-hb-blob.o
libtool: compile:  /usr/bin/g++-4.2 -DHAVE_CONFIG_H -I. -I.. -pthread -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include/freetype2 -I./hb-ucdn -I/opt/local/include -pipe -Os -arch ppc -std=c++11 -fno-rtti -fno-exceptions -Wcast-align -fvisibility-inlines-hidden -MT libharfbuzz_la-hb-buffer-serialize.lo -MD -MP -MF .deps/libharfbuzz_la-hb-buffer-serialize.Tpo -c hb-buffer-serialize.cc  -fno-common -DPIC -o .libs/libharfbuzz_la-hb-buffer-serialize.o
cc1plus: error: unrecognized command line option "-std=c++11"
cc1plus: error: unrecognized command line option "-std=c++11"

Attachments (1)

Portfile.diff (726 bytes) - added by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez) 7 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 7 years ago by Schamschula (Marius Schamschula)

Cc: Schamschula added

comment:2 Changed 7 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Cc: MarcusCalhoun-Lopez added

Changed 7 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Attachment: Portfile.diff added

comment:3 Changed 7 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Keywords: haspatch added

comment:4 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

Grumble. I had looked in the NEWS file and there was no mention of a new C++11 requirement in 1.6.x.

comment:5 Changed 7 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

As noted in the original post, PortGroup cxx11 1.1 solves the problem for all systems.
harfbuzz seems to go out of its way to minimize the parts of C++11 it uses.
If affecting the smallest number of systems is desirable (Xcode 4 systems for example), the attached patch does that.

Last edited 7 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez) (previous) (diff)

comment:6 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ballapete added
Summary: harfbuzz 1.6.1 : cc1plus: error: unrecognized command line option "-std=c++11"harfbuzz @1.6.3: cc1plus: error: unrecognized command line option "-std=c++11"

Has duplicate #55191.

Upstream is removing the C++11 requirement; see https://github.com/behdad/harfbuzz/issues/585

comment:7 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

In 38bdb8ebd6cbaaf98fc63d04084c0a190e59e86c/macports-ports:

harfbuzz: Keep Snow Leopard and earlier on harfbuzz 1.5.1

See: #55165

comment:8 in reply to:  7 Changed 7 years ago by ballapete (Peter "Pete" Dyballa)

Replying to ryandesign:

In 38bdb8ebd6cbaaf98fc63d04084c0a190e59e86c/macports-ports:

harfbuzz: Keep Snow Leopard and earlier on harfbuzz 1.5.1

See: #55165

I think harfbuzz-icu needs to be handled the same way.

comment:9 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

harfbuzz-icu is a subport of harfbuzz, so the above commit handles it too.

comment:10 Changed 7 years ago by ballapete (Peter "Pete" Dyballa)

Both ports built fine on PPC Leopard and Tiger with configure.compiler=macports-gcc-6.

comment:11 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

Yes but since 1.6.4 will build with the default compiler I'm going to wait until that is released before making it available to Snow Leopard and earlier.

comment:12 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed

In a8c4e9e43decbb6cac951b42a5591468e325d53b/macports-ports:

harfbuzz: Update to 1.7.1

Closes: #55165

Note: See TracTickets for help on using tickets.