Opened 7 years ago
Closed 7 years ago
#55221 closed enhancement (fixed)
wxWidgets-3.0-libcxx: remove the port
Reported by: | mojca (Mojca Miklavec) | Owned by: | mojca (Mojca Miklavec) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | MarcusCalhoun-Lopez (Marcus Calhoun-Lopez), yan12125 (Chih-Hsuan Yen) | |
Port: | FileZilla, wxWidgets-3.0-libcxx |
Description
I would like to suggest getting rid of wxWidgets-libcxx (now that we have wxWidgets-cxx11 anyway).
It seems that only FileZilla is trying to use it (it was me who added that weird code long time ago), but I'm pretty sure that FileZilla in its current form is not supported on < 10.9. I don't know whether using cxx11 1.1
would help in any way.
Attachments (1)
Change History (8)
comment:1 Changed 7 years ago by mojca (Mojca Miklavec)
Port: | wxWidgets-3.0-libcxx added; wxWidgets-libcxx removed |
---|---|
Summary: | wxWidgets-libcxx: remove the port → wxWidgets-3.0-libcxx: remove the port |
comment:2 follow-up: 4 Changed 7 years ago by mojca (Mojca Miklavec)
Changed 7 years ago by mojca (Mojca Miklavec)
Attachment: | FileZilla.Portfile.diff added |
---|
Replace wxWidgets in FileZilla
comment:3 Changed 7 years ago by mojca (Mojca Miklavec)
Yen: I atteched my proposed changes for FileZilla. Can you please have a look. It would probably be most interesting to test this on 10.7 or 10.8. If this works fine, my next step would be to get rid of wxWidgets-3.0-libcxx
as there's really no need for it.
comment:4 Changed 7 years ago by kencu (Ken)
Replying to mojca:
file.cpp:142:14: error: use of undeclared identifier 'O_CLOEXEC'
int flags = O_CLOEXEC;
1 error generated. }}}
This error is noted now and then on 10.6.8. Sometimes I have seen it fixed properly, by manually closing the file after using it. Most often, with many examples on MacPorts, it is just defined to 0
like this:
configure.cppflags-append -DO_CLOEXEC=0
comment:5 Changed 7 years ago by kencu (Ken)
fixing O_CLOEXEC gets further on 10.6, but there is at least one further missing function not yet replaced by snowleopard_fixes. Will have to work on this more later, but for now it is still broken on 10.6.
comment:6 Changed 7 years ago by mojca (Mojca Miklavec)
comment:7 Changed 7 years ago by mojca (Mojca Miklavec)
Owner: | set to mojca |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Random note. The
libfilezilla
library can still be compiled on 10.7. On 10.6 it fails to build with the same error as reported here:Just as a reference point when thinking about how far back we might want to go with testing.