xhyve 20170117: fail to build

[giorgiga (Giorgio Gallo)]

$ sudo port install xhyve
--->  Building xhyve
Error: Failed to build xhyve: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_xhyve/xhyve/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets to report a bug.
Error: Processing of port xhyve failed

$ tail /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_xhyve/xhyve/main.log
:info:build 	CompileC build/xhyve.build/Release/xhyve.build/Objects-normal/x86_64/pci_virtio_net_tap.o src/pci_virtio_net_tap.c normal x86_64 c com.apple.compilers.llvm.clang.1_0.compiler
:info:build (1 failure)
:info:build Command failed: cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_xhyve/xhyve/work/xhyve-181d34c5053c03439a1c709bc7d933b6aa9e305c" && /usr/bin/xcodebuild  -alltargets -configuration Deployment build INSTALL_PREFIX=/opt/local CODE_SIGN_ENTITLEMENTS="" CODE_SIGN_IDENTITY="" INSTALL_PATH="/opt/local/bin" OBJROOT=build/ SYMROOT=build/ MACOSX_DEPLOYMENT_TARGET=10.13 ARCHS=x86_64 SDKROOT="" GCC_VERSION=com.apple.compilers.llvm.clang.1_0 CLANG_CXX_LIBRARY="libc++" 
:info:build Exit code: 65
:error:build Failed to build xhyve: command execution failed
:debug:build Error code: NONE
:debug:build Backtrace: command execution failed
:debug:build     while executing
:debug:build "$procedure $targetname"
:error:build See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_xhyve/xhyve/main.log for details.

[giorgiga (Giorgio Gallo)]

Full /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_xhyve/xhyve/main.log

[giorgiga (Giorgio Gallo)]

Not sure if it's relevant, but here's what I get trying to manually execute the failing command:

$ cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_xhyve/xhyve/work/xhyve-181d34c5053c03439a1c709bc7d933b6aa9e305c"
$ sudo /usr/bin/xcodebuild  -alltargets -configuration Deployment build INSTALL_PREFIX=/opt/local CODE_SIGN_ENTITLEMENTS="" CODE_SIGN_IDENTITY="" INSTALL_PATH="/opt/local/bin" OBJROOT=build/ SYMROOT=build/ MACOSX_DEPLOYMENT_TARGET=10.13 ARCHS=x86_64 SDKROOT="" GCC_VERSION=com.apple.compilers.llvm.clang.1_0 CLANG_CXX_LIBRARY="libc++"
Build settings from command line:
    ARCHS = x86_64
    CLANG_CXX_LIBRARY = libc++
    CODE_SIGN_ENTITLEMENTS = 
    CODE_SIGN_IDENTITY = 
    GCC_VERSION = com.apple.compilers.llvm.clang.1_0
    INSTALL_PATH = /opt/local/bin
    INSTALL_PREFIX = /opt/local
    MACOSX_DEPLOYMENT_TARGET = 10.13
    OBJROOT = build/
    SDKROOT = 
    SYMROOT = build/

--- xcodebuild: WARNING: Configuration Deployment is not in the project. Building default configuration.

=== BUILD TARGET xhyve OF PROJECT xhyve WITH THE DEFAULT CONFIGURATION (Release) ===

and, after lots of text that I'm omitting (see the full output in attachment):

CompileC build/xhyve.build/Release/xhyve.build/Objects-normal/x86_64/vpmtmr.o src/vmm/io/vpmtmr.c normal x86_64 c com.apple.compilers.llvm.clang.1_0.compiler
    cd /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_xhyve/xhyve/work/xhyve-181d34c5053c03439a1c709bc7d933b6aa9e305c
    export LANG=en_US.US-ASCII
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x c -arch x86_64 -fmessage-length=120 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -fcolor-diagnostics -std=gnu11 -fmodules -gmodules -fmodules-prune-interval=86400 -fmodules-prune-after=345600 -fbuild-session-file=/var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/C/org.llvm.clang/ModuleCache/Session.modulevalidation -fmodules-validate-once-per-build-session -Wnon-modular-include-in-framework-module -Werror=non-modular-include-in-framework-module -Wno-trigraphs -fpascal-strings -Os -flto -fno-common -Werror -Wno-missing-field-initializers -Wno-missing-prototypes -Werror=return-type -Werror=objc-root-class -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wunused-label -Wunused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wconditional-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wno-float-conversion -Wno-non-literal-null-conversion -Wno-objc-literal-conversion -Wshorten-64-to-32 -Wpointer-sign -Wno-newline-eof -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -fasm-blocks -fstrict-aliasing -Wdeprecated-declarations -mmacosx-version-min=10.13 -g -fvisibility=hidden -Wsign-conversion -Wno-infinite-recursion -Wno-comma -Wno-block-capture-autoreleasing -Wno-strict-prototypes -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_xhyve/xhyve/work/xhyve-181d34c5053c03439a1c709bc7d933b6aa9e305c/build/xhyve.build/Release/xhyve.build/xhyve.hmap -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_xhyve/xhyve/work/xhyve-181d34c5053c03439a1c709bc7d933b6aa9e305c/build/Release/include -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_xhyve/xhyve/work/xhyve-181d34c5053c03439a1c709bc7d933b6aa9e305c/include -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_xhyve/xhyve/work/xhyve-181d34c5053c03439a1c709bc7d933b6aa9e305c/build/xhyve.build/Release/xhyve.build/DerivedSources/x86_64 -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_xhyve/xhyve/work/xhyve-181d34c5053c03439a1c709bc7d933b6aa9e305c/build/xhyve.build/Release/xhyve.build/DerivedSources -Weverything -Wall -Wno-error=deprecated -Wno-unknown-warning-option -Wno-reserved-id-macro -Wno-missing-variable-declarations -pedantic -F/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_xhyve/xhyve/work/xhyve-181d34c5053c03439a1c709bc7d933b6aa9e305c/build/Release -fstrict-aliasing -include xhyve-version.h -fvisibility=hidden -MMD -MT dependencies -MF /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_xhyve/xhyve/work/xhyve-181d34c5053c03439a1c709bc7d933b6aa9e305c/build/xhyve.build/Release/xhyve.build/Objects-normal/x86_64/vpmtmr.d --serialize-diagnostics /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_xhyve/xhyve/work/xhyve-181d34c5053c03439a1c709bc7d933b6aa9e305c/build/xhyve.build/Release/xhyve.build/Objects-normal/x86_64/vpmtmr.dia -c /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_xhyve/xhyve/work/xhyve-181d34c5053c03439a1c709bc7d933b6aa9e305c/src/vmm/io/vpmtmr.c -o /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_xhyve/xhyve/work/xhyve-181d34c5053c03439a1c709bc7d933b6aa9e305c/build/xhyve.build/Release/xhyve.build/Objects-normal/x86_64/vpmtmr.o

** BUILD FAILED **


The following build commands failed:
	CompileC build/xhyve.build/Release/xhyve.build/Objects-normal/x86_64/pci_virtio_net_tap.o src/pci_virtio_net_tap.c normal x86_64 c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

[giorgiga (Giorgio Gallo)]

full output of "sudo /usr/bin/xcodebuild ..."

[mf2k (Frank Schima)]

In the future, please fill in the Port field and Cc the port maintainers (port info --maintainers xhyve), if any.

[jeremyhu (Jeremy Huddleston Sequoia)]

	/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_xhyve/xhyve/work/xhyve-181d34c5053c03439a1c709bc7d933b6aa9e305c/src/pci_virtio_net_tap.c:405:7: error:
403	      implicit declaration of function 'select' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
404	                if (select((sc->vsc_tapfd + 1), &rfd, NULL, NULL, NULL) == -1) {
405	                    ^
406	/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_xhyve/xhyve/work/xhyve-181d34c5053c03439a1c709bc7d933b6aa9e305c/src/pci_virtio_net_tap.c:405:7: error:
407	      missing '#include <sys/time.h>'; declaration of 'select' must be imported from module 'Darwin.POSIX.sys.time'
408	      before it is required
409	In module 'Darwin' imported from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_xhyve/xhyve/work/xhyve-181d34c5053c03439a1c709bc7d933b6aa9e305c/src/pci_virtio_net_tap.c:30:
410	/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/sys/_select.h:39:6: note:
411	      previous declaration is here
412	int      select(int, fd_set * __restrict, fd_set * __restrict,
413	         ^
414	2 errors generated.
415	

[giorgiga (Giorgio Gallo)]

Didn't notice that - good catch!

I fear I have not enough knowledge of ports builds (or, C builds in general) to be really useful, but:

• I have been able to build xhyve locally with no problem whatsoever (git clone ... && cd ... && make)
• according to github, pci_virtio_net_tap.c has not been touched since June 2016

Heve you been able to reproduce? Can I run any test/diagnostic and be of use?

[danchr (Dan Villiom Podlaski Christiansen)]

In e932039bec1ee7b11d35d56f88bedbcdd0031da1/macports-ports:

xhyve: add patch to fix build (maintainer timeout)

Closes: #55323

[danchr (Dan Villiom Podlaski Christiansen)]

In d2ac66d1ffe959fce563610605ea3afeb378dbcc/macports-ports:

xhyve: use note to point at codesign (maintainer timeout)

The note is standard infrastructure, and can be seen later on using
'port note'.

References: #55323