Opened 7 years ago

Last modified 7 years ago

#55418 assigned defect

gds @2.17.7_1: error: ordered comparison between pointer and zero

Reported by: rxa254 (Rana Adhikari) Owned by: ed.maros@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: john.zweizig@…
Port: gds

Description

Latest GDS (2.17.7_1) is failing to build. Quick perusal of the log file seems to indicate this due to "PulsarMon"

Attachments (1)

gds-main.log (3.0 MB) - added by rxa254 (Rana Adhikari) 7 years ago.
log file from failed build

Change History (2)

Changed 7 years ago by rxa254 (Rana Adhikari)

Attachment: gds-main.log added

log file from failed build

comment:1 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: gds PulsarMon removed
Owner: set to ed.maros@…
Port: gds added
Status: newassigned
Summary: GDS fails to build on Sierragds @2.17.7_1: error: ordered comparison between pointer and zero

The log says:

:info:build PulsarMon.cc:264:14: error: ordered comparison between pointer and zero ('FILE *' (aka '__sFILE *') and 'int')
:info:build             if (tmp < 0) perror("Unable to divert stderr");
:info:build                 ~~~ ^ ~
:info:build PulsarMon.cc:268:14: error: ordered comparison between pointer and zero ('FILE *' (aka '__sFILE *') and 'int')
:info:build             if (tmp < 0) perror("Unable to divert stdout");
:info:build                 ~~~ ^ ~
:info:build 2 errors generated.

This is clearly a bug in the source. Nobody should ever check if a pointer is less than zero; that will never occur.

A newer version of gds is available upstream. Maybe they've already fixed this problem. Ed, can you update the port?

$ port livecheck gds
gds seems to have been updated (port version: 2.17.7, new version: 2.18.3)
Note: See TracTickets for help on using tickets.