Opened 7 years ago

Closed 6 years ago

#55421 closed defect (fixed)

unixODBC @2.3.2: Fix paths in nntp.driver.template and tds.driver.template

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: unixODBC

Description

The paths in the installed files nntp.driver.template and tds.driver.template contain the unreplaced placeholder _DP_PREFIX: 

$ grep /lib/ /opt/local/share/unixODBC/*
/opt/local/share/unixODBC/nntp.driver.template:Driver			= _DP_PREFIX/lib/libnn.so
/opt/local/share/unixODBC/nntp.driver.template:Setup			= _DP_PREFIX/lib/libodbcnnS.so
/opt/local/share/unixODBC/postgresql.driver.template:Driver			= /opt/local/lib/libodbcpsql.so
/opt/local/share/unixODBC/postgresql.driver.template:Setup			= /opt/local/lib/libodbcpsqlS.so
/opt/local/share/unixODBC/tds.driver.template:Driver			= _DP_PREFIX/lib/libtdsodbc.so
/opt/local/share/unixODBC/tds.driver.template:Setup			= _DP_PREFIX/lib/libtdsS.so

The paths in the file postgresql.driver.template properly contain the actual prefix, /opt/local.

Looks like this got screwed up in r11771, 12.5 years ago. You never noticed this problem?

The current version of MacPorts gives us a hint at installation time that something is amiss: 

Warning: reinplace s|__PREFIX__|/opt/local|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_databases_unixODBC/unixODBC/work/destroot/opt/local/share/unixODBC/nntp.driver.template
Warning: reinplace s|__PREFIX__|/opt/local|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_databases_unixODBC/unixODBC/work/destroot/opt/local/share/unixODBC/tds.driver.template

The fix is to change the placeholder in the nntp.driver.template and tds.driver.template files from _DP_PREFIX to __PREFIX__ to match postgresql.driver.template.

The port's revision will need to be increased when this is done, since the change affects installed files.

Change History (2)

comment:1 Changed 7 years ago by kurthindenburg (Kurt Hindenburg)

Owner: simon@… deleted
Status: new → assigned

comment:2 Changed 6 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: set to ryandesign
Resolution: → fixed
Status: assigned → closed

In e78d36dfb7aa0e738ff724fb0f33774c6172c0a3/macports-ports (master):

unixODBC: Fix reinplace in template files

Closes: #55421

Note: See TracTickets for help on using tickets.