curl port opportunistically links against brotli

[francoisbecker (François Becker)]

The curl port opportunistically links against brotli whereas brotli isn't declared as a dependency of the curl port. This is an issue for example with curl+universal whereas brotli-universal is installed (port fails to install)

Suggestion: curl should either never use brotli (e.g. by passing --disable-brotli), or declare a dependency on it.

[neverpanic (Clemens Lang)]

This results in the following failure on installation:

diff -u /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_net_curl/curl/work/destroot-{i386,x86_64}/opt/local/bin/curl-config
--- /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_net_curl/curl/work/destroot-i386/opt/local/bin/curl-config  2017-11-30 15:10:00.000000000 +0100
+++ /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_net_curl/curl/work/destroot-x86_64/opt/local/bin/curl-config        2017-11-30 15:09:59.000000000 +0100
 -148,7 +148,7 @@
            CURLLIBDIR=""
         fi
         if test "Xyes" = "Xyes"; then
-          echo ${CURLLIBDIR}-lcurl -lidn2 -lpsl -lssl -lcrypto -lssl -lcrypto -lz
+          echo ${CURLLIBDIR}-lcurl -lidn2 -lpsl -lssl -lcrypto -lssl -lcrypto -lbrotlidec -lz
         else
           echo ${CURLLIBDIR}-lcurl
         fi
 -156,7 +156,7 @@
 
     --static-libs)
         if test "Xyes" != "Xno" ; then
-          echo ${exec_prefix}/lib/libcurl.a -L/opt/local/lib -Wl,-headerpad_max_install_names  -L/opt/local/lib -L/opt/local/lib -L/opt/local/lib -lidn2 -lpsl -lssl -lcrypto -lssl -lcrypto -lz
+          echo ${exec_prefix}/lib/libcurl.a -L/opt/local/lib -Wl,-headerpad_max_install_names  -L/opt/local/lib -L/opt/local/lib -L/opt/local/lib -lidn2 -lpsl -lssl -lcrypto -lssl -lcrypto -lbrotlidec -lz
         else
           echo "curl was built with static libraries disabled" >&2
           exit 1

[ryandesign (Ryan Carsten Schmidt)]

brotli builds with cmake. cmake links with curl. So we cannot make brotli a dependency of curl because that would cause a circular dependency and MacPorts doesn't support that.

[ryandesign (Ryan Carsten Schmidt)]

In e5ccd4490ed35e608bbb46dcb843d09673dce9d2/macports-ports:

curl: Explicitly disable brotli support

Closes: #55438