Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#55485 closed enhancement (fixed)

Update ansible dependency

Reported by: emiel (Emiel van de Laar) Owned by: Andrew Fernandes <andrew@…>
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: zdw (Zack Williams), adfernandes@…, adfernandes (Andrew Fernandes), blair@…, pedro.salgado@…
Port: ansible-lint

Description

The ansible port has been split up to support different Python versions. The ansible port has been deprecated in favor of py-ansible, pyXX-ansible. Should ansible-lint follow suit? Let me know if I can assist.

Change History (5)

comment:1 Changed 7 years ago by mf2k (Frank Schima)

Cc: zdw adfernandes@… adfernandes blair@… pedro.salgado@… added
Type: updateenhancement

So it sounds like we need to add py-ansible-lint to follow.

comment:2 Changed 7 years ago by adfernandes (Andrew Fernandes)

Does ansible-lint handle Python 3?

If not, does this create a potential conflict between a py3 Ansible and ansible-lint?

Looking at the github page (https://github.com/willthames/ansible-lint) it seems that ansible-lint is totally independent of Ansible, no?

If they are independent, I'll just version-bump ansible-lint and patch as follows:

-github.setup        willthames ansible-lint 3.4.13 v
+github.setup        willthames ansible-lint 3.4.19 v

and

-depends_run-append  port:ansible
+depends_run-append  bin:ansible:py-ansible

(fixing checksums, etc, of course)

comment:3 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

You don't want to use bin:ansible:py-ansible because that would allow an ansible binary not installed by MacPorts to satisfy the dependency. To allow the binary to have been installed by one of several MacPorts ports, but not by something outside of MacPorts, use a path:-style dependency instead.

Also, it tells MacPorts that if ansible does not exist, it should install py-ansible, and that py-ansible will provide the ansible binary. But that's false; in fact, one of the subports, such as py27-ansible, provides the binary.

So it would be better to write path:bin/ansible:py27-ansible.

comment:4 Changed 7 years ago by Andrew Fernandes <andrew@…>

Owner: set to Andrew Fernandes <andrew@…>
Resolution: fixed
Status: newclosed

In 7d16378c1566eff991e88067e3cf2486c6c9ed57/macports-ports:

ansible-lint: update to handle the change in the ansible port

  • minor version bump
  • depend on the new py-ansible port

Closes: #55485

comment:5 Changed 7 years ago by emiel (Emiel van de Laar)

Awesome! Thanks guys.

Note: See TracTickets for help on using tickets.