Opened 7 years ago

Closed 7 years ago

#55531 closed update (fixed)

npm5 @5.5.1: update to 5.6.0

Reported by: l2dy (Zero King) Owned by: light@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: mohd-akram (Mohamed Akram)
Port: npm5

Description


Attachments (2)

npm5.patch​ (2.6 KB) - added by mmpestorich (Mike M Pestorich) 7 years ago.
npm-try-2.patch​ (2.8 KB) - added by blair (Blair Zajac) 7 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by mohd-akram (Mohamed Akram)

Cc: mohd-akram added

Changed 7 years ago by mmpestorich (Mike M Pestorich)

Attachment: npm5.patch​ added

comment:2 Changed 7 years ago by mmpestorich (Mike M Pestorich)

Here's a patch that updates the version to 5.6.0 and modifies the macports specific patch to lib/update.js

comment:3 in reply to:  2 Changed 7 years ago by l2dy (Zero King)

Replying to mmpestorich:

Here's a patch that updates the version to 5.6.0 and modifies the macports specific patch to lib/update.js

This new patch would return with toInstall[key].what = [] if toInstall[key] doesn't exist, while the original code will return with toInstall[key].what = [ww.what]. Is this change intentional?

Changed 7 years ago by blair (Blair Zajac)

Attachment: npm-try-2.patch​ added

comment:4 Changed 7 years ago by blair (Blair Zajac)

I added a patch that doesn't update toInstall at all. Can you review this? I can push this commit myself if you like.

comment:5 Changed 7 years ago by blair (Blair Zajac)

Resolution: → fixed
Status: new → closed

In 7d1e1ab57dd34d77632640ad1c7af0170aa20703/macports-ports:

npm5: new upstream 5.6.0 release.

Maintainer timeout.

Fixes: #55531

Note: See TracTickets for help on using tickets.