Opened 7 years ago

Closed 6 years ago

#55669 closed defect (fixed)

iTerm2 @3.1.5 compile error

Reported by: rlmaers (Rafael Lukas Maers) Owned by: markemer (Mark Anderson)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: iterm2

Description

There's a misspelled include in iTermInitialDirectory.h that leads to a compilation error.

See https://github.com/gnachman/iTerm2/commit/4a5fc0ec75d40859aa7e3cfea7c6a1d4fef4553f

The build completed successfully after I applied the patch locally.

Attachments (1)

main.log (213.4 KB) - added by rlmaers (Rafael Lukas Maers) 7 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 7 years ago by mf2k (Frank Schima)

Cc: markemer removed
Owner: set to markemer
Status: newassigned

comment:2 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

It compiles fine for me... Can you attach the main.log showing the build failure?

comment:3 Changed 7 years ago by markemer (Mark Anderson)

Yeah works fine for me too. Like Ryan said, can you show us the main.log?

comment:4 Changed 7 years ago by markemer (Mark Anderson)

If we don't hear back soon, and no one else complains, I say we close this.

Changed 7 years ago by rlmaers (Rafael Lukas Maers)

Attachment: main.log added

comment:5 Changed 7 years ago by rlmaers (Rafael Lukas Maers)

Sorry for the wait. See attached main.log for details.

comment:6 Changed 7 years ago by markemer (Mark Anderson)

Cool. I’ll take a look. It still builds out of the box for me on 10.13, which seems strange.

comment:7 Changed 6 years ago by markemer (Mark Anderson)

We should close this, 3.1.6 fixes it. And so will 3.1.7 once I get it building

comment:8 Changed 6 years ago by markemer (Mark Anderson)

Can we close this? It's no longer valid with 3.1.7

comment:9 Changed 6 years ago by markemer (Mark Anderson)

Anyone? This isn't relevant anymore. Can someone close this? I would, but I don't think I can.

comment:10 Changed 6 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.