Opened 7 years ago

Closed 2 years ago

Last modified 2 years ago

#55940 closed enhancement (fixed)

Don't import suffix into global namespace

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: jmroot (Joshua Root)
Priority: Normal Milestone: MacPorts 2.8.0
Component: base Version: 2.4.99
Keywords: Cc:
Port:

Description

portfetch.tcl has these lines:

# XXX import suffix into the global namespace as it is currently used from
# Portfiles, but should better go somewhere else
namespace import portfetch::suffix

We removed the use of the suffix proc from most portfiles years ago in commits such as these:

The only remaining port using it is my FFView port and I should remove it from there too.

So can we stop importing suffix into the global namespace now?

Change History (3)

comment:1 Changed 2 years ago by jmroot (Joshua Root)

Owner: set to jmroot
Resolution: fixed
Status: newclosed

In dc186734c80bcc38222c3746e19ddc67666bbd42/macports-base (master):

Stop exporting portfetch::suffix

Closes: #55940

comment:2 Changed 2 years ago by jmroot (Joshua Root)

Milestone: MacPorts Future

comment:3 Changed 2 years ago by jmroot (Joshua Root)

Milestone: MacPorts FutureMacPorts 2.8.0
Note: See TracTickets for help on using tickets.