Opened 7 years ago
Closed 6 years ago
#56121 closed submission (fixed)
openfortivpn @1.6.0_0
Reported by: | millerdev (Daniel Miller) | Owned by: | |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | ||
Port: | openfortivpn |
Description
Submission of openfortivpn Portfile
Attachments (2)
Change History (7)
comment:1 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
Port: | openfortivpn added |
---|
comment:2 Changed 7 years ago by millerdev (Daniel Miller)
Updated.
Please use the github portgroup. See documentation in the guide. Please use tarball download, not archive download...
I had tried this earlier but it always failed to download the file from github. The documentation on github portgroup seems incomplete for a project with automatically generated releases (based on tags), so ended up reading the source and guessing. The details that made it work were:
github.tarball_from tags
- and setting
gh_tag_prefix
(thev
at the end ofgithub.setup adrienverge openfortivpn 1.6.0 v
).
Please provide an example if this is still not correct.
Please add size to checksums.
The instructions in the guide are incomplete on this, and port -v checksum
does not suggest output that meets your requirements. I had to guess on how to get this right (by adding a fake size 0
checksum) before port -v checksum
gave the correct details.
Please run autogen.sh the way we do in other ports...
I hope I did this correctly (added to configure.cmd
). I guessed based on this example. If this is still wrong, please point me to an example of how to do it correctly.
Changed 7 years ago by millerdev (Daniel Miller)
Changed 7 years ago by millerdev (Daniel Miller)
Attachment: | Portfile.2 added |
---|
comment:3 Changed 7 years ago by millerdev (Daniel Miller)
@ryandesign not sure if you want separate attachments. Reverted "Portfile" attachment to the original and added "Portfile.2" with the updates.
comment:4 Changed 6 years ago by millerdev (Daniel Miller)
Submitted PR on github: https://github.com/macports/macports-ports/pull/2026
comment:5 Changed 6 years ago by mf2k (Frank Schima)
Resolution: | → fixed |
---|---|
Status: | new → closed |
Thanks for the submission. Please use the github portgroup. See documentation in the guide. Please use tarball download, not archive download, and adjust checksums to match. Please add size to checksums. Please run autogen.sh the way we do in other ports, not by manually running it with
system
.