enchant2 +applespell fails to build on Yosemite and earlier

[jeremyhu (Jeremy Huddleston Sequoia)]

On macOS 10.10 Yosemite and earlier, echant2 is failing to install with the +applespell variant. It looks like this is a new dependency of gspell as of a couple weeks ago (bb147c99f1bd5b6e80dedc8d56ac98db7a4faec4).

enchant 1.6.0_5 installed ok with this variant when I built it last a few months ago.

:info:build /bin/sh ../libtool   --tag=CXX  --mode=compile /usr/bin/clang++ -DHAVE_CONFIG_H -I. -I..  -I.. -I../lib -I../lib -I../src -D_REENTRANT -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include  -D_ENCHANT_BUILD=1 -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.10.sdk  -pipe -Os -stdlib=libc++ -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.10.sdk -arch x86_64 -MT enchant_applespell_la-applespell_checker.lo -MD -MP -MF .deps/enchant_applespell_la-applespell_checker.Tpo -c -o enchant_applespell_la-applespell_checker.lo `test -f 'applespell_checker.mm' || echo './'`applespell_checker.mm
:info:build libtool: compile:  /usr/bin/clang++ -DHAVE_CONFIG_H -I. -I.. -I.. -I../lib -I../lib -I../src -D_REENTRANT -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -D_ENCHANT_BUILD=1 -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.10.sdk -pipe -Os -stdlib=libc++ -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.10.sdk -arch x86_64 -MT enchant_applespell_la-applespell_checker.lo -MD -MP -MF .deps/enchant_applespell_la-applespell_checker.Tpo -c applespell_checker.mm  -fno-common -DPIC -o .libs/enchant_applespell_la-applespell_checker.o
:info:build applespell_checker.mm:47:28: error: type arguments cannot be applied to non-parameterized class 'NSArray'
:info:build         char **         NSArrayToCArray (NSArray<NSString *> *array, size_t *nresult);
:info:build                                          ^      ~~~~~~~~~~~~
:info:build applespell_checker.mm:125:44: error: type arguments cannot be applied to non-parameterized class 'NSArray'
:info:build char **AppleSpellChecker::NSArrayToCArray (NSArray<NSString *> *array, size_t *nresult)
:info:build                                            ^      ~~~~~~~~~~~~
:info:build applespell_checker.mm:205:2: error: type arguments cannot be applied to non-parameterized class 'NSArray'
:info:build         NSArray<NSString *>* result = [m_checker guessesForWordRange:range inString:str language:lang inSpellDocumentWithTag:0];
:info:build         ^      ~~~~~~~~~~~~
:info:build applespell_checker.mm:242:2: error: type arguments cannot be applied to non-parameterized class 'NSArray'
:info:build         NSArray<NSString *> *availLanguages = [m_checker availableLanguages];
:info:build         ^      ~~~~~~~~~~~~
:info:build applespell_checker.mm:243:2: error: type arguments cannot be applied to non-parameterized class 'NSMutableArray'
:info:build         NSMutableArray<NSString *> *availDicts = [NSMutableArray arrayWithCapacity:[availLanguages count]];
:info:build         ^             ~~~~~~~~~~~~
:info:build 5 errors generated.

enchant2 is written in a way that depends on the macOS 10.11 or later SDK.

[jeremyhu (Jeremy Huddleston Sequoia)]

See also ​https://trac.macports.org/ticket/51287

[jeremyhu (Jeremy Huddleston Sequoia)]

In 0b5d4f5aed0389e1d1778951d14f47400d8a7a60/macports-ports:

enchant2: Default to +aspell rather than +applespell on Yosemite+

Fixes: #56222

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@…>