Opened 7 years ago

Closed 4 years ago

#56252 closed enhancement (fixed)

macosx_version should contain the full macOS version

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by:
Priority: Normal Milestone: MacPorts 2.7.0
Component: base Version: 2.4.99
Keywords: Cc: kurthindenburg (Kurt Hindenburg)
Port:

Description

I'd like to see the full macOS version (e.g. 10.12.6) in the main.log, but annoyingly, macosx_version only contains the major macOS version (e.g. 10.12). Jeremy briefly changed it to the full version, but there are places in MacPorts base that assume it is only the major version, so that change was quickly reverted.

Can we revisit this idea of changing (some might say correcting) the meaning of macosx_version? Most of the ports that use the variable already accommodate this, since they use vercmp when testing that variable. I fixed the wine ports which were doing the comparison wrong, and I sent a PR for libcxx; after that's merged, all the ports should be ok.

Base still has a few places that use string comparison on that variable, but I'm happy to fix those up if we agree to make this change.

Alternately, we could keep macosx_version as is and add a new variable for the full version, as Josh suggested, but I don't think that's the best solution.

Change History (4)

comment:1 Changed 4 years ago by kurthindenburg (Kurt Hindenburg)

Cc: kurthindenburg added
Milestone: MacPorts Future

comment:2 Changed 4 years ago by kurthindenburg (Kurt Hindenburg)

or https://github.com/macports/macports-base/pull/181 which adds a new variable as jmr objects to !180

comment:3 Changed 4 years ago by kurthindenburg (Kurt Hindenburg)

Ryan do you want to comment on the pulls? People prefer the new variable.

comment:4 Changed 4 years ago by jmroot (Joshua Root)

Milestone: MacPorts FutureMacPorts 2.7.0
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.