Opened 7 years ago
Closed 7 years ago
#56332 closed update (fixed)
gnome-internet-radio-locator 1.1.0
| Reported by: | oleaamot (Ole Aamot) | Owned by: | raimue (Rainer Müller) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch maintainer | Cc: | |
| Port: | gnome-internet-radio-locator |
Description (last modified by oleaamot (Ole Aamot))
gnome-internet-radio-locator 1.1.0 is available for free under GNU General Public License version 3 (or later) from https://download.gnome.org/sources/gnome-internet-radio-locator/1.1/gnome-internet-radio-locator-1.1.0.tar.xz with build fixes.
See the attached diff for the new Portfile against https://github.com/macports/macports-ports/blob/master/gnome/gnome-internet-radio-locator/Portfile
Best, Ole
Attachments (3)
Change History (13)
Changed 7 years ago by oleaamot (Ole Aamot)
Changed 7 years ago by oleaamot (Ole Aamot)
| Attachment: | patch-enable-debug.diff added |
|---|
gnome-internet-radio-locator 1.1.0 enable debug patch
comment:1 Changed 7 years ago by oleaamot (Ole Aamot)
| Description: | modified (diff) |
|---|
comment:2 Changed 7 years ago by oleaamot (Ole Aamot)
| Description: | modified (diff) |
|---|
comment:3 Changed 7 years ago by mf2k (Frank Schima)
A quick comment.
You have added the active_variants portgroup, but it is not being used. It should be removed.
comment:4 follow-up: 5 Changed 7 years ago by mf2k (Frank Schima)
| Type: | defect → update |
|---|
comment:5 Changed 7 years ago by oleaamot (Ole Aamot)
Replying to mf2k:
OK, I have updated the patch.
comment:6 Changed 7 years ago by raimue (Rainer Müller)
Your patch says it is against version 1.0.7. The submitted patch for 1.0.7 contained other changes as well. What is supposed to be applied now?
comment:7 Changed 7 years ago by oleaamot (Ole Aamot)
The patch for 1.0.7 contained some changes for gdk-quartz variant, but I was unable to compile gnome-internet-radio-locator for gdk-quartz, so my changes were removed in 1.0.8.
The latest patch for 1.1.0 is a diff against
https://github.com/macports/macports-ports/blob/master/gnome/gnome-internet-radio-locator/Portfile
and could be applied.
comment:8 follow-up: 9 Changed 7 years ago by raimue (Rainer Müller)
Portfile-1.1.0.diff is a diff against version 1.0.7 (the Portfile in macports-ports is at 1.0.6), which is why I was asking.
Changed 7 years ago by oleaamot (Ole Aamot)
| Attachment: | Portfile-1.1.0.diff added |
|---|
gnome-internet-radio-locator 1.1.0 Portfile patch against 1.0.6
comment:9 Changed 7 years ago by oleaamot (Ole Aamot)
Replying to raimue:
Portfile-1.1.0.diff is a diff against version 1.0.7 (the Portfile in macports-ports is at 1.0.6), which is why I was asking.
OK, I have added a diff against version 1.0.6 (the Portfile in macports) for 1.1.0.
Thanks in advance.
comment:10 Changed 7 years ago by raimue (Rainer Müller)
| Owner: | set to raimue |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Portfile for gnome-internet-radio-locator 1.1.0