Opened 7 years ago

Closed 2 years ago

#56347 closed defect (fixed)

cfitsio @3.440_0: install_name not set correctly in configure patch, leading to incorrect rev-upgrade behaviour

Reported by: aszostak-partner-eso-org Owned by:
Priority: Normal Milestone:
Component: ports Version: 2.4.2
Keywords: haspatch Cc:
Port: cfitsio

Description

The patch-configure.diff patch file is making a modification where the value to -install_name is not being set correctly. This is leading to "sudo port rev-upgrade" to incorrectly think that packages that depend on cfitsio do not need to be rebuilt, when in fact they do.

The attached patch applied to the current macports-ports source should fix this problem.

Attachments (1)

patch.txt​ (1.4 KB) - added by aszostak-partner-eso-org 7 years ago.
Patch to cfitsio to fix problem with install_name setting.

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by aszostak-partner-eso-org

Attachment: patch.txt​ added

Patch to cfitsio to fix problem with install_name setting.

comment:1 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: cdeil removed
Owner: set to cdeil
Status: new → assigned

comment:2 Changed 7 years ago by pmetzger (Perry E. Metzger)

FYI, you may find your patch gets somewhat faster consideration of you send a GitHub pull request for it. Instructions are available in the MacPorts guide if you're not familiar with pull requests.

comment:3 Changed 6 years ago by ryandesign (Ryan Carsten Schmidt)

Since this changes the install_name of the library, all ports linking with this library need to have their revisions increased.

comment:4 Changed 5 years ago by mf2k (Frank Schima)

Owner: cdeil deleted

comment:5 Changed 2 years ago by kencu (Ken)

Resolution: → fixed
Status: assigned → closed

fixed, likely by ​https://github.com/macports/macports-ports/commit/27a78d0fa499c233e4cb7e7136ad0080df81cdc2

Note: See TracTickets for help on using tickets.