Opened 7 years ago
Closed 7 years ago
#56389 closed defect (fixed)
rrdtool @1.7.0: fix missing dependency for dejavu-fonts
Reported by: | pdvnl | Owned by: | ctreleaven (Craig Treleaven) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.4.3 |
Keywords: | haspatch | Cc: | macports@… |
Port: | rrdtool |
Description
rrdtool
expects to find its default fonts DejaVuSans
and DejaVuSansMono
, but there is no dependency defined.
Here I propose a patch to Portfile to add the missing depends-run dejavu-fonts
.
Note: as rrdtool
currently has nomaintainer
you could assign it to me.
Attachments (1)
Change History (10)
comment:1 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
Keywords: | haspatch added; fix missing dependency dejavu-fonts removed |
---|---|
Port: | dejavufonts removed |
comment:3 Changed 7 years ago by pmetzger (Perry E. Metzger)
Please submit this as a GitHub pull request if you can. Then it will be acted on far faster. Instructions are available in the MacPorts Guide if you need them.
comment:5 Changed 7 years ago by pdvnl
I don't understand why. rrdtool had no maintainer
, I worked myself through the code of rrdtool pango cairo and now think I know what I'm talking about, Ryan said to change it, so why?
comment:6 Changed 7 years ago by ctreleaven (Craig Treleaven)
Re openmaintainer, see the Maintainers section under:
https://guide.macports.org/#reference.keywords
Basically, adding openmaintainer gives prior approval to others to make minor corrections or updates to the port. It is the usual case, especially for port maintained by those without commit rights.
comment:7 Changed 7 years ago by pdvnl
OK. now with open maintainer added.
next I'll try to make a PR.
Changed 7 years ago by pdvnl
Attachment: | patch-rrdtool-Portfile.diff added |
---|
comment:8 Changed 7 years ago by ctreleaven (Craig Treleaven)
Owner: | set to ctreleaven |
---|---|
Status: | new → assigned |
comment:9 Changed 7 years ago by ctreleaven (Craig Treleaven)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
If you wish to maintain the port, feel free to modify the
maintainers
line appropriately in your patch.