Opened 7 years ago
Closed 7 years ago
#56438 closed update (fixed)
aspell-dict-sv: add license and update version number
| Reported by: | aque (Allan Que) | Owned by: | jakob@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.4.4 |
| Keywords: | Cc: | ||
| Port: | aspell-dict-sv |
Description
I am requesting maintainer approval for the attached patch. It makes the following changes to the aspell-dict-sv Portfile:
- fix whitespace
- add modeline
- update version following upstream format
- fix livecheck
- add license
- add noarch
- use configure.args instead of calling system
- update checksums with new file hashes
- format port to follow other aspell-dict-* Portfile
The Portfile passes a lint --nitpick check and I verified it successfully installed.
Attachments (3)
Change History (8)
Changed 7 years ago by aque (Allan Que)
| Attachment: | aspell-dict-sv.patch added |
|---|
comment:1 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
comment:2 Changed 7 years ago by aque (Allan Que)
I thought about submitting this as a Github PR since that is my preference, but the maintainer does not have a handle I can @mention. That's why I submitted this as a Trac ticket; I am hoping the maintainer gets the email notification.
I can still create a PR and reference this ticket, but I thought that was frowned upon. Let me know how you want to proceed. In the meantime, I'll create a separate patch for the whitespace change.
Changed 7 years ago by aque (Allan Que)
| Attachment: | aspell-dict-sv-2.patch added |
|---|
functional changes
comment:3 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
Patches here are fine.
When I've previously sent PRs for users whose GitHub handles aren't known, I've privately sent them an email with the PR URL.
comment:4 Changed 7 years ago by raimue (Rainer Müller)
comment:5 Changed 7 years ago by raimue (Rainer Müller)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Please make whitespace changes separately from functional changes; combining them in one diff makes it difficult to review the functional changes because they're difficult to see.
It may be easier to submit a pull request on GitHub with two commits (one to update the whitespace and add the modeline, another to do the functional changes), rather than attach separate diff files here.