Opened 6 years ago
Closed 6 years ago
#56586 closed enhancement (fixed)
Useless emacs patches
| Reported by: | wyuenho (Jimmy Yuen Ho Wong) | Owned by: | drkp (Dan Ports) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | ||
| Port: | emacs-app |
Description
The emacs-app port currently is applying two patches, both have their problems:
- patch*-src_emacs.c.diff - that add MacPort's prefix to the PATH of emacs but not /usr/local/bin or any other paths in the shell's environment, this patch is a half done solution to solve the PATH problem when launching Emacs.app from the Finder. A good solution to this problem (https://github.com/purcell/exec-path-from-shell) has been around for 6 years now. I suggest we remove this, so there's less maintenance.
- patch-enable-multicolor-fonts.diff - this patch was originally added to reenable emoji inputs, but it hasn't worked for months now. Every time an emoji is inserted, emacs crashes. I suggest we remove this patch unless a quick and easy solution is found to reimplement emoji input on MacOS.
Change History (4)
comment:1 Changed 6 years ago by jmroot (Joshua Root)
| Owner: | set to drkp |
|---|---|
| Port: | emacs-app added |
| Status: | new → assigned |
comment:2 Changed 6 years ago by l2dy (Zero King)
patch-enable-multicolor-fonts.diff still works for me. You need to choose the multicolor_font variant and set the "Apple Color Emoji" font in your init file.
comment:4 Changed 6 years ago by wyuenho (Jimmy Yuen Ho Wong)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
Please remember to fill in the Port field and Cc the maintainer.