Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#56627 closed defect (fixed)

Upstream mtr package has wrong version

Reported by: dgilman (David Gilman) Owned by: Schamschula (Marius Schamschula)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: Schamschula (Marius Schamschula)
Port: mtr

Description

The upstream MTR tarball was created with an incorrect version number and this was packaged into the autoconf build scripts. If you run mtr --version you'll see 0.91.1-4c982 instead of 0.92. Please re-run bootstrap.sh as part of the build to give the binary the correct version.

Change History (4)

comment:1 Changed 6 years ago by Schamschula (Marius Schamschula)

Unfortunately, if you run bootstrap.sh or set use_autoreconf to yes, you will get mtr UNKNOWN

See ​https://github.com/traviscross/mtr/issues/229

comment:2 Changed 6 years ago by dgilman (David Gilman)

The git-version-gen function is weird and the --fallback flag only works when git itself is not installed. But this patch puts the right version number in configure and the resulting binary: 

--- ../mtr/configure.ac	2018-06-08 08:51:54.610437193 -0400
+++ configure.ac	2018-06-08 08:52:23.359539561 -0400
@@ -1,6 +1,6 @@
 AC_PREREQ([2.59])
 AC_INIT([mtr],
-  [m4_esyscmd([build-aux/git-version-gen .tarball-version])],
+  [0.92])],
   [R.E.Wolff@BitWizard.nl], [],
   [http://www.BitWizard.nl/mtr/])
 AC_CONFIG_SRCDIR([ui/mtr.c])
Last edited 6 years ago by dgilman (David Gilman) (previous) (diff)

comment:3 Changed 6 years ago by Schamschula (Marius Schamschula)

Owner: set to Schamschula
Resolution: → fixed
Status: new → closed

In 759cdf278ce60154a111019811f1ad8998a1560e/macports-ports (master):

mtr 0.92: fix version string

Closes: #56627

comment:4 Changed 5 years ago by neverpanic (Clemens Lang)

In 440141456b1ec427b6a81499b2b683fcc26db5a3/macports-ports (master):

mtr: Drop unnecessary reinplace and workaround

The reinplace no longer matches anything and the timestamps of the
shipped config.h.in also seem to be fine, since building in trace mode
now works again without this change.

Reverts 5ba5586109a2a8fdb5048c3b20a888951982484e and
c93f614233d2e2eed505f91c9b6dd9ced5ff557a.

See: #56627

Note: See TracTickets for help on using tickets.