Opened 6 years ago

Closed 6 years ago

#56645 closed defect (fixed)

zstd @1.3.4: opportunistically links with libz, liblz4, liblzma

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: seanfarley (Sean Farley)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: zstd

Description (last modified by ryandesign (Ryan Carsten Schmidt))

When not using the universal variant, zstd will link with libz, liblz4 and liblzma if they are present:

$ port deps zstd
zstd @1.3.4_0 has no dependencies.
$ otool -L /opt/local/bin/zstd
/opt/local/bin/zstd:
	/opt/local/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
	/opt/local/lib/liblzma.5.dylib (compatibility version 8.0.0, current version 8.4.0)
	/opt/local/lib/liblz4.1.dylib (compatibility version 1.0.0, current version 1.8.2)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1238.60.2)

The zstd port should declare dependencies on the zlib, lz4 and xz ports and make their use explicit via configure args.

Or, if the use of these libraries is not desired, the port must ensure they are not used, even if they are installed.

Whichever solution is chosen, the revision will need to be increased.

Change History (4)

comment:1 Changed 6 years ago by ryandesign (Ryan Carsten Schmidt)

Description: modified (diff)

comment:2 Changed 6 years ago by seanfarley (Sean Farley)

Ah, didn't realize that. I think zstd should just declare those dependencies.

comment:3 Changed 6 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added

comment:4 Changed 6 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

In 815d231e23039f491eaea1b7c52d20bb7f7ede5a/macports-ports (master):

zstd: Update to 1.3.7

Closes: #57597

Add dependencies on lz4, xz, and zlib, which were previously linked
opportunistically.

Closes: #56645

Fix detection of pthread, lz4, xz, and zlib when building universal.

Closes: #56646

Add a patch to fix compilation on i386.

Closes: #57544

Enable tests.

Note: See TracTickets for help on using tickets.