Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#56669 closed defect (fixed)

ldns 1.7.0 ./configure fails to find the SDK on MacOS X <= 10.6

Reported by: grumpybozo (Bill Cole) Owned by:
Priority: Normal Milestone:
Component: ports Version: 2.5.2
Keywords: haspatch upstream Cc:
Port: ldns

Description

The root cause is reliance on "xcrun --show-sdk-version" to identify the proper SDK version. The "--show-sdk-version" option did not exist in the xcrun utility until MacOS X 10.7 (XCode 4.)

The attached patch to configure.ac fixes (after running autoreconf) this problem for MacOS X 10.6. I have submitted it upstream as well: ​https://www.nlnetlabs.nl/bugs-script/show_bug.cgi?id=4105

Attachments (1)

configure.ac.diff​ (901 bytes) - added by grumpybozo (Bill Cole) 6 years ago.
Patch to configure.ac

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by grumpybozo (Bill Cole)

Attachment: configure.ac.diff​ added

Patch to configure.ac

comment:1 Changed 6 years ago by jmroot (Joshua Root)

The problem is, we don't really want the configure script to decide which SDK and deployment target to use. We'd like it to use the MACOSX_DEPLOYMENT_TARGET that we set in the environment, and the -isysroot option that we put in CFLAGS (which may be none).

comment:2 in reply to:  description Changed 6 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to grumpybozo:

The root cause is reliance on "xcrun --show-sdk-version" to identify the proper SDK version. The "--show-sdk-version" option did not exist in the xcrun utility until MacOS X 10.7 (XCode 4.)

xcrun --show-sdk-version does not work before OS X 10.8 / Xcode 5.

comment:3 Changed 5 years ago by grumpybozo (Bill Cole)

Keywords: update added

This has been fixed in upstream v1.7.1, using my patch.

comment:4 Changed 5 years ago by yan12125 (Chih-Hsuan Yen)

Resolution: → fixed
Status: new → closed

ldns is updated to 1.7.1 in [30467d225b8d59c8c38b7bfeb971663a14c424f8/macports-ports], and further issues in building on 10.6 is fixed with [162736257bd7e94b2d2d72d60c527ed9196aa0ba/macports-ports].

comment:5 in reply to:  4 Changed 5 years ago by jmroot (Joshua Root)

Replying to yan12125:

further issues in building on 10.6 is fixed with [162736257bd7e94b2d2d72d60c527ed9196aa0ba/macports-ports].

That failure was actually on 10.11, but yeah, that's doing what I said in comment:1.

comment:6 Changed 5 years ago by mf2k (Frank Schima)

Keywords: update removed
Note: See TracTickets for help on using tickets.