Opened 6 years ago

Closed 6 years ago

#56717 closed defect (fixed)

webkit2-gtk @2.20.3 fails to build

Reported by: tehcog (tehcog) Owned by: jeremyhu (Jeremy Huddleston Sequoia)
Priority: Normal Milestone:
Component: ports Version: 2.5.2
Keywords: Cc: dbevans (David B. Evans)
Port: webkit2-gtk

Description

Mavericks. Please see attached main.log

Attachments (1)

main.log.gz (3.1 MB) - added by tehcog (tehcog) 6 years ago.
main.log

Change History (6)

Changed 6 years ago by tehcog (tehcog)

Attachment: main.log.gz added

main.log

comment:1 Changed 6 years ago by kencu (Ken)

yeah, this was anticipated after the recent update. I will be digging in on the older systems over the next few days or so.

comment:2 Changed 6 years ago by kencu (Ken)

I think the particular error in this ticket should be fixed by restricting the following patch to systems < darwin13

    # fix a Cursor name collision with Carbon API
    # https://trac.macports.org/ticket/52016
    if {[variant_isset x11]} {
        patchfiles-append patch-snowleopard-npruntime-redefine-cursor.diff
    }

Something like this should do it:

    # fix a Cursor name collision with Carbon API
    # https://trac.macports.org/ticket/52016
    if {[variant_isset x11] && ${os.major} < 13} {
        patchfiles-append patch-snowleopard-npruntime-redefine-cursor.diff
    }

I will try that soon. webkit2-gtk takes a long time to build, to edit-compile-test cycles are measured in hours rather than minutes. If you care to try it out yourself and report back that would be much appreciated!

Last edited 6 years ago by kencu (Ken) (previous) (diff)

comment:3 Changed 6 years ago by mf2k (Frank Schima)

Cc: jeremyhu removed
Owner: set to jeremyhu
Status: newassigned

comment:4 Changed 6 years ago by kencu (Ken)

OK. Progress:

$ port -v installed webkit2-gtk
The following ports are currently installed:
  webkit2-gtk @2.18.0_0+gtk2+x11 platform='darwin 10' archs='x86_64' date='2017-11-10T15:13:21-0800'
  webkit2-gtk @2.20.3_0+gtk2+x11 (active) platform='darwin 10' archs='x86_64' date='2018-06-23T00:06:24-0700'

I will try a new build soon.

comment:5 Changed 6 years ago by Ken <21211439+kencu@…>

Resolution: fixed
Status: assignedclosed

In 200cc18f1e40b9c3dc54b554dcf1e0116e7c1838/macports-ports (master):

webkit2-gtk: fix build on older systems

this should fix the errors noted on the buildbots
disable JIT on 10.6.8
no longer need to patch out Cursor name collision it appears
closes: #56717

Note: See TracTickets for help on using tickets.