Opened 6 years ago
Closed 6 years ago
#56750 closed update (fixed)
py-pysvn: latest version is 1.9.6
| Reported by: | josephsacco | Owned by: | reneeotten <reneeotten@…> |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | |
| Port: | py-pysvn |
Description
The Portfile and patch file have been updated to support py-pysvn @1.9.6 for python versions: 27, 34, 35, and 36.
- py27-pysvn and py36-pysvn build with minor warnings. [I have no other versions of python installed]
- All tests in the source Test directory pass for each build.
FWIW... The build currently fails for python37.
-Joseph
Attachments (4)
Change History (10)
comment:1 Changed 6 years ago by mf2k (Frank Schima)
| Keywords: | haspatch added; has patches removed |
|---|---|
| Version: | 2.5.2 |
Changed 6 years ago by josephsacco
| Attachment: | Portfile_py-pysvn.diff added |
|---|
updated Portfile_py-pysvn.diff
comment:2 Changed 6 years ago by josephsacco
Updated Updated Portfile_py-pysvn.diff and py-graveyard [See #56751]
-Joseph
comment:3 Changed 6 years ago by josephsacco
I have updated the Portfile to support python3.7. In addition, I added a patch for Import/pycxx-7.0.3/Src/IndirectPythonInterface.cxx to eliminate a cast problem. I also modified the original patch for Source/setup_configure.py.
The previous version of the Portfile set worksrcdir to ${worksrcdir}/Source. That was OK when everything when patch, configure, and build were done from the Source directory. With the addition of the new patch, the source needed to be patched in two different directories. I set patch.dir to the original ${worksrcpath} and modified the two patch files to work from the top of the application source tree. . I then added a line just before pre-configure to reset worksrcdir to ${worksrcdir}/Source. That actually worked.
With the new version of the Portfile and the two patches, py-pysvn builds for py27, py36, and py37.
-Joseph
Changed 6 years ago by josephsacco
| Attachment: | patch-Source_setup_configure.py.diff added |
|---|
patch-Source_setup_configure.py.diff 24July2018
Changed 6 years ago by josephsacco
| Attachment: | patch-IndirectPythonInterface.cxx.diff added |
|---|
patch-IndirectPythonInterface.cxx.diff 24July2018
comment:4 Changed 6 years ago by reneeotten (Renee Otten)
hi josephsacco,
thanks for the updates/patches to several Python ports recently. I have taken some of those (including this one) and submitted them as a PR on GitHub for incorporation in MacPorts. If you are familiar with git/GitHub (see https://trac.macports.org/wiki/WorkingWithGit for useful pointers) you might consider submitting your changes as a PR instead of Trac tickets. From my experience (as a new contributor) that process is fast and efficient, and there are always people willing to help out when you run into trouble.
comment:5 Changed 6 years ago by josephsacco
Renee,
Thank you for the suggestion. I will look into it.
-Joseph
comment:6 Changed 6 years ago by reneeotten <reneeotten@…>
| Owner: | set to reneeotten <reneeotten@…> |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Only add py36. No need to add python versions that will be removed soon and that you haven't tested anyway. When removing py26, the py-graveyard port should be updated with it too.