gdal: add fits variant

[mazhe (Matthieu Volat)]

Hello,

The gdal library can have support for the FITS image format used in astronomy through the cfitsio project. While gdal already have a lot of variants, it would be super useful to have this one added.

Attached is a patch to the Portfile that allows this, could this be commited to the port?

Thank you very much for your time,

[kencu (Ken)]

To make this variant work the way you want it to, you'd have to leave

--without-cfitsio \

as it is in the default configure arguments (as you want it off by default).

Then, in your variant, you can do this replacement:

variant fits description {Enable FITS file format} {
    depends_lib-append       port:cfitsio
    configure.args-replace   --without-cfitsio    --with-cfitsio
}

[mazhe (Matthieu Volat)]

Simpler patch.

[mazhe (Matthieu Volat)]

Ho, thanks. I'm not that familiar with Portfile syntax, I just copied what was done in other parts of the file.

Here's an updated version.

[kencu (Ken)]

Yeah, I think that should do it. Let's give Vince (the maintainer) time to check it out now. -- K

[mazhe (Matthieu Volat)]

Hi, is there any progress or comment regarding this request? priority is not that high, but it would be nice to have it done!

Thanks again,

[kencu (Ken)]

Vince hasn't noticed this one so far I guess.

I'll put together a PR for this (or you can if you like). Then it will get committed after a short while if it passes muster on the CI system.

[Veence (Vincent)]

Oops. I apologize. Will work on this tonight.

[ryandesign (Ryan Carsten Schmidt)]

A cfitsio variant was added in [e3f7c230c2e0baf64bf5cb715dc16b70f2d8ed72/macports-ports]