qemu @2.12.0_1 +target_or32 configure fails with errors in qemu-conf.c

[ShadSterling (Shad Sterling)]

Looks like the wrong compiler is being used; I expect the relevant errors are these:

/usr/bin/clang -m64 -mcx16 -DOS_OBJECT_USE_OBJC=0 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wno-error=address-of-packed-member -Wno-string-plus-int -Wno-initializer-overrides -Wexpansion-to-defined -Wendif-labels -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Werror -Wold-style-declaration -o config-temp/qemu-conf.exe config-temp/qemu-conf.c -m64 -framework CoreFoundation -framework IOKit -g -L/opt/local/lib -Wl,-headerpad_max_install_names -arch x86_64
error: unknown warning option '-Wold-style-declaration'; did you mean '-Wout-of-line-declaration'? [-Werror,-Wunknown-warning-option]

/usr/bin/clang -m64 -mcx16 -DOS_OBJECT_USE_OBJC=0 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wno-error=address-of-packed-member -Wno-string-plus-int -Wno-initializer-overrides -Wexpansion-to-defined -Wendif-labels -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-definition -Wtype-limits -fstack-protector-strong -Wno-missing-braces -Werror -fno-gcse -o config-temp/qemu-conf.exe config-temp/qemu-conf.c -m64 -framework CoreFoundation -framework IOKit -g -L/opt/local/lib -Wl,-headerpad_max_install_names -arch x86_64
clang: error: optimization flag '-fno-gcse' is not supported [-Werror,-Wignored-optimization-argument]

On macOS High Sierra 10.13.5 (17F77), XCode Version 9.4.1 (9F2000), Command Line Tools 9.4

---

There are also several errors messages which I expect are part of normal operation; Most of those are of this form:

/usr/bin/clang -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -c -o c
onfig-temp/qemu-conf.o config-temp/qemu-conf.c
config-temp/qemu-conf.c:2:2: error: __linux__ not defined
#error __linux__ not defined

And one is different:

/usr/bin/clang -m64 -mcx16 -DOS_OBJECT_USE_OBJC=0 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wno-error=address-of-packed-member -Wno-string-plus-int -Wno-initializer-overrides -Wexpansion-to-defined -Wendif-labels -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-definition -Wtype-limits -fstack-protector-strong -Werror -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c
config-temp/qemu-conf.c:3:8: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
} x = {0};
       ^
       {}
1 error generated.

[raimue (Rainer Müller)]

The real error message in the normal output:

:info:configure ERROR: Unknown target name 'or32-softmmu'

I had missed that or32 was renamed to or1k in the latest release. I am working on an update to correct this.

[raimue (Rainer Müller)]

In 698e7e18f7d878fbf837085870798c45e33b2081/macports-ports (master):

qemu: Fix +target_or32 variant

The or32 target was renamed to or1k a while ago, but the port was not
updated accordingly. Rename the existing variant to +target_or1k and
create a compatiblity variant +target_or32 that will allow upgrades from
the previous name.

Closes: #56790