iTerm2 built in updater should be disabled

[rlhamil]

iTerm2's built in updater is active, and even defaults to check in its preferences. Since apps installed via MacPorts should really only be updated via MacPorts, this could result in inconsistencies if someone used the builtin updater; so it should be disabled and if possible, hidden.

[mf2k (Frank Schima)]

In the future, please add the port maintainer(s) to Cc (port info --maintainers iTerm2), if any.

[markemer (Mark Anderson)]

Ok, so it seems like key below controls the sparkle updates. Setting it to 0 should kill the popup boxes. I'm going to make sure it works and then add it to the portfile.

defaults read com.googlecode.iterm2.plist SUEnableAutomaticChecks

[Tatsh (Andrew Udvare)]

Replying to markemer:

Ok, so it seems like key below controls the sparkle updates. Setting it to 0 should kill the popup boxes. I'm going to make sure it works and then add it to the portfile.

defaults read com.googlecode.iterm2.plist SUEnableAutomaticChecks

This won't work as this defaults key is only for the user profile, not root. Still the best thing is to stub the update functions and disable/remove the checkbox and the menu entry.

[Tatsh (Andrew Udvare)]

PR that does this ​https://github.com/macports/macports-ports/pull/9042

[Tatsh <Tatsh@…>]

In 22a786199c868842f0108f31f2955c17f8bab21c/macports-ports (master):

iTerm2: disable automatic update functionality (​https://github.com/macports/macports-ports/pull/9042)

• iTerm2: disable automatic update functionality

Closes: #56840

• iTerm2: guard against undefined NS_WARN_UNUSED_RESULT