hdf5 +gcc8 build failure in H5detect.c

[mf2k (Frank Schima)]

I'm seeing the following build failure with hdf5 +gcc8:

:info:build H5detect.c:1575:1: error: expected end of line before 'ignored'
:info:build      DETECT_I(unsigned long long,  ULLONG,       d_g[nd_g]); nd_g++;
:info:build  ^   ~~
:info:build H5detect.c:1575:1: error: expected end of line before 'pop'
:info:build H5detect.c:1602:1: error: attributes should be specified before the declarator in a function definition
:info:build  static void
:info:build  ^~~~~~
:info:build H5detect.c:1628:1: error: attributes should be specified before the declarator in a function definition
:info:build  static void
:info:build  ^~~~~~
:info:build H5detect.c:1640:55: error: expected end of line before 'push'
:info:build      DETECT_F(long double,      LDOUBLE,      d_g[nd_g]); nd_g++;
:info:build                                                        ^
:info:build H5detect.c:1640:1: error: expected end of line before 'ignored'
:info:build      DETECT_F(long double,      LDOUBLE,      d_g[nd_g]); nd_g++;
:info:build  ^   ~~
:info:build H5detect.c:1640:1: error: expected end of line before 'pop'
:info:build H5detect.c:1640:1: error: expected end of line before 'push'
:info:build H5detect.c:1640:1: error: expected end of line before 'ignored'
:info:build H5detect.c:1640:1: error: expected end of line before 'pop'
:info:build H5detect.c:1659:1: error: attributes should be specified before the declarator in a function definition
:info:build  static void
:info:build  ^~~~~~
:info:build H5detect.c:1747:1: error: attributes should be specified before the declarator in a function definition
:info:build  int
:info:build  ^~~

[Dave-Allured (Dave Allured)]

This issue with gcc8 was reported to HDF Group about 3 months ago. This thread on HDF community forum shows the issue and suggests code patches for H5detect.c.

​https://forum.hdfgroup.org/t/1-10-2-h5detect-compile-error-gcc-8-1-0-on-centos-7-2-solved/4441

[mamoll (Mark Moll)]

In ab245a11a665f368bc728afc534f7ae35cc3def4/macports-ports (master):

science/hdf5: fix gcc8 compilation error. closes #56977

[Dave-Allured (Dave Allured)]

Thanks Mark for your quick response.

Also this bug in H5detect.c is fixed in pre-release HDF5 1.10.3-pre1. Bottom line, gcc8 is more pedantic than gcc7 about the position of attributes in function declarations.

​https://portal.hdfgroup.org/display/support/Downloads

... However I am not suggesting that this port be updated to the pre-release. Just wait for the official 1.10.3 release, and Mark's patch should be fine in the meantime.