#57040 closed defect (fixed)
[Port Abandoned] ola
Reported by: | pmetzger (Perry E. Metzger) | Owned by: | nomis52 |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | p3k (Tobi Schäfer), peternewman (Peter Newman) | |
Port: | ola |
Change History (11)
comment:1 Changed 6 years ago by pmetzger (Perry E. Metzger)
Cc: | p3k peternewman added |
---|
comment:2 Changed 6 years ago by pmetzger (Perry E. Metzger)
comment:3 Changed 6 years ago by pmetzger (Perry E. Metzger)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:4 Changed 6 years ago by peternewman (Peter Newman)
Hi pmetzger,
We're still here, I was just on holiday and hence away from keyboard for the last two weeks, hence not responding to this.
I see we've overlapped responding too.
comment:5 Changed 6 years ago by pmetzger (Perry E. Metzger)
You didn't reply to bug reports filed in April. That's quite a long holiday. There is an expectation that maintainers will respond to bug reports and emails a bit faster than that.
comment:6 Changed 6 years ago by peternewman (Peter Newman)
Assuming you're referring to #56387, I was partly waiting to see on a final outcome in #56135, as there didn't seem to be a complete consensus. I was also sort of hoping our 0.11.0 release (which includes the patch) would come in before we became the only blocker on protobuf3, thereby avoiding having to spend time on packaging and prioritising actually writing code.
What's the process now, would you prefer openmaintainer and myself being a bit slow to respond to some issues, or nomaintainer and OLA people having no easy way to see any issues related to the port (unless people report them to upstream)?
comment:7 Changed 6 years ago by mf2k (Frank Schima)
I would say open a new PR with the 0.11.0 update and add yourself back as maintainer with openmaintainer.
comment:8 Changed 6 years ago by pmetzger (Perry E. Metzger)
Assuming you're referring to #56387, I was partly waiting to see on a final outcome in #56135,
You didn't reply after months. That's not the same as waiting. There's also plenty of consensus, which you would have learned about if you had bothered to reply. I am very tolerant of lots of stuff, but failing to say anything for a long time is a problem.
As for "nomaintainer", that doesn't stop you from either looking at tickets or submitting PRs for fixes, but if you would like to be the maintainer, that's fine if you respond to tickets within a few days rather than in six months.
comment:9 Changed 6 years ago by pmetzger (Perry E. Metzger)
(Basically I'm saying, yes, sure, it's fine for you to be the maintainer, but agreeing to be the maintainer implies an agreement that you will respond reasonably fast to tickets going forward.)
comment:10 Changed 6 years ago by peternewman (Peter Newman)
I'm generally very busy around the end of April/start of May too unfortunately. Just looking back and in fact I did reply just elsewhere (you asked "is there a set of patches I can apply"): https://github.com/OpenLightingProject/ola/issues/1192#issuecomment-384365506 And I replied pointing you to them: https://github.com/OpenLightingProject/ola/issues/1192#issuecomment-384379273
So I suspect when I saw #56387 I was assuming you might make the change too, having asked what needed changing.
In actual fact, having made the patch file, it turns out there's another patch needed too, but that's also in OLA's GitHub pulls.
I don't believe I get any build failed emails if I'm not listed as a maintainer, and I certainly wouldn't get CCed into tickets automatically. Obviously as upstream we're best placed to know when a new release is out. As I'm not a Mac user, ideally someone else would do the MacPorts updates who gets more benefit from it and/or is more familiar with MacPorts infrastructure (and I can spend more time on the OLA codebase bit I know best), but there don't currently appear to be any takers currently; I assumed openmaintainer might help that too.
comment:11 Changed 6 years ago by mf2k (Frank Schima)
You can definitely be a maintainer without being a Mac user. You can submit PRs updating the ola port with version updates because you only need to also update the checksums which are not platform dependent (of course). Travis will tell us if it builds correctly.
We seem to have passed 72 hours...