iTerm2: Update to 3.2.5

[ryandesign (Ryan Carsten Schmidt)]

$ port livecheck iTerm2
iTerm2 seems to have been updated (port version: 3.2.0, new version: 3.2.2)

[stanimura]

iTerm2 is now 3.2.5.

$ port livecheck iTerm2
iTerm2 seems to have been updated (port version: 3.2.0, new version: 3.2.5)

[markemer (Mark Anderson)]

I'm currently working on 3.2.5 - but it dies in a funny place. I'm investigating.

[markemer (Mark Anderson)]

Can we update this title to 3.2.5 - and also, the problem I'm having is related to #57137 - but I can't seem to get ${xcode.target} to work for me, the port command pleads ignorance.

[ryandesign (Ryan Carsten Schmidt)]

Replying to markemer:

Can we update this title to 3.2.5

Done.

and also, the problem I'm having is related to #57137

I had hoped someone using Mojave would have fixed that by now.

but I can't seem to get ${xcode.target} to work for me, the port command pleads ignorance.

What do you mean?

[markemer (Mark Anderson)]

Ok, I worked it out, I'm not not using the Xcode portgroup because there is a makefile and the Xcode portgroup doesn't play well with makefiles. But now I'm back to my starting problem, where 3.2.5 won't build on 10.14 which is the system I'm developing on. I think I may have to change the Makefile patch to include adding -derivedData

[ryandesign (Ryan Carsten Schmidt)]

Yes, on Xcode 10 or later I think we need to use -derivedData. We should do that in the xcode portgroup, and ports that invoke xcodebuild manually would have to add that as well.

The question is: is there a good reason why the iTerm2 port should use that Makefile? It looks like almost all of what the Makefile does is of use only to the developer, not to us. Literally all it's doing in the build phase (the Deployment target) is

	xcodebuild -parallelizeTargets -target iTerm2 -configuration Deployment && \
	chmod -R go+rX build/Deployment

and the destroot phase (the install target) is just:

	cp -R build/Deployment/iTerm2.app $(APPS)

It should be extremely easy to replace that with the xcode portgroup, and then you'd automatically get the benefit of any improvement made to that portgroup.

[yan12125 (Chih-Hsuan Yen)]

This has been fixed with ​​https://github.com/macports/macports-ports/pull/3060 and ​​https://github.com/macports/macports-ports/pull/3033. Moreover, I've updated iTerm2 to 3.2.6 in 7f905c8ccecab3d715ff64e90cd31676c2312304/macports-ports.