Opened 6 years ago
Last modified 16 months ago
#57256 assigned defect
gtkglext has enormous configure patches
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | rowue (Rolf Würdemann), cooljeanius (Eric Gallager) | |
| Port: | gtkglext |
Description
gtkglext's files directory has 2 enormous (> 750 KiB, > 22,000 line) patchfiles for the configure script, one of which isn't even used by the portfile.
Nobody is going to be able to read patchfiles that large to determine what they change or why or be able to update them in the future, which is probably one reason why they haven't been touched in 9 years.
The patches were originally added due to #20968. Rolf, do you remember how the configure patches were created?
The diffs are so large because the configure script was originally generated by autoconf 2.59 and the revised version was generated by autoconf 2.61.
If the diffs merely regenerate the configure script with a newer version of autoconf, then it would be simpler to remove the configure patchfiles and just have the portfile run autoreconf.
If configure.ac had also been changed before autoreconf was run, then it would be simpler to have the port patch configure.ac and then run autoreconf.
Change History (3)
comment:1 Changed 6 years ago by mf2k (Frank Schima)
| Owner: | jd@… deleted |
|---|
comment:2 Changed 4 years ago by cooljeanius (Eric Gallager)
| Cc: | cooljeanius added |
|---|
comment:3 Changed 16 months ago by ryandesign (Ryan Carsten Schmidt)
Replying to ryandesign:
one of which isn't even used by the portfile.
Deleted in [4e8a279eed3ebb5d8a56c7446dbede5cd8bed626/macports-ports].
See #57123.