VLC @2.2.8_6: Build and runtime errors on Mojave

[michaellass (Michael Lass)]

There are currently two distinct problems causing VLC not to work under MacOS Mojave:

1. VLC suffers from #57234, so it only builds with XCode 10 when forcing use of the old build system. I did that by patching extras/package/macosx/package.mak: ​git commit

2. After successfully building VLC, it crashes on startup with the following error:

VLC media player 2.2.8 Weatherwax (revision 2.2.7-14-g3cc1d8cba9)
[00007fac80d0d638] core libvlc: VLC wird mit dem Standard-Interface ausgeführt. Benutzen Sie 'cvlc', um VLC ohne Interface zu verwenden.
2018-10-05 14:36:57.130 VLC[25942:8168183] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'NSWindow drag regions should only be invalidated on the Main Thread!'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007fff340cd43d __exceptionPreprocess + 256
	1   libobjc.A.dylib                     0x00007fff5ffde720 objc_exception_throw + 48
	2   CoreFoundation                      0x00007fff340e6ec1 -[NSException raise] + 9
	3   AppKit                              0x00007fff315eb2a5 -[NSWindow(NSWindow_Theme) _postWindowNeedsToResetDragMarginsUnlessPostingDisabled] + 324
	4   AppKit                              0x00007fff315f24ba -[NSView(NSInternal) _updateDragRegionForHiddenStateChange] + 73
	5   AppKit                              0x00007fff315e029f -[NSView(NSInternal) _setHidden:setNeedsDisplay:] + 1236
	6   libmacosx_plugin.dylib              0x000000010e8b6b26 -[VLCControlsBarCommon drawFancyGradientEffectForTimeSlider] + 262
	7   AppKit                              0x00007fff31693abd -[NSView(NSInternal) _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:] + 1545
	8   AppKit                              0x00007fff316934a2 __46-[NSView(NSLayerKitGlue) drawLayer:inContext:]_block_invoke + 192
	9   AppKit                              0x00007fff31693201 -[NSView(NSLayerKitGlue) _drawViewBackingLayer:inContext:drawingHandler:] + 1769
	10  QuartzCore                          0x00007fff3efa7aaf CABackingStoreUpdate_ + 577
	11  QuartzCore                          0x00007fff3f009325 ___ZN2CA5Layer8display_Ev_block_invoke + 53
	12  QuartzCore                          0x00007fff3efa6c90 -[CALayer _display] + 1839
	13  AppKit                              0x00007fff3169275a _NSBackingLayerDisplay + 531
	14  AppKit                              0x00007fff31676cc9 -[_NSViewBackingLayer display] + 811
	15  QuartzCore                          0x00007fff3efbd214 _ZL16display_callbackPvS_ + 64
	16  QuartzCore                          0x00007fff3efbd16d _ZN2CA13DispatchGroup8dispatchEb + 49
	17  libdispatch.dylib                   0x00007fff6105ddcb _dispatch_client_callout + 8
	18  libdispatch.dylib                   0x00007fff61064120 _dispatch_lane_serial_drain + 618
	19  libdispatch.dylib                   0x00007fff61064bd8 _dispatch_lane_invoke + 388
	20  libdispatch.dylib                   0x00007fff6106d084 _dispatch_workloop_worker_thread + 603
	21  libsystem_pthread.dylib             0x00007fff6129d61c _pthread_wqthread + 409
	22  libsystem_pthread.dylib             0x00007fff6129d415 start_wqthread + 13
)
libc++abi.dylib: terminating with uncaught exception of type NSException
Abort trap: 6

Unfortunately I have no clue how to deal with the second problem. Of course, I can provide the fix for problem number 1 as a pull request but I'd rather get it working before.

If relevant: I am building VLC with +quartz -x11.

[RJVB (René Bertin)]

Can you please try the test port from #56799?

If that also fails with the same exception you'd have to file a bug @videolan.org (if they don't already have a new release out fixing the issue). And/or revert to a less new-fangled OS ... come back from the desert ;)

[michaellass (Michael Lass)]

Both issues are solved in VLC-test (i.e., VLC 3.0.4). So this issue should be solved once VLC 3 enters the ports tree.

[michaellass (Michael Lass)]

Thanks @RJVB for bringing VLC 3 into macports! From my side, this ticket can be closed (#56799 as well I guess).