libosmo-dsp: fatal error: '/usr/include/complex.h' file not found

[ryandesign (Ryan Carsten Schmidt)]

​libosmo-dsp does not build on Mojave:

iqbal.c:cfile.c43:33:10: cxvec_math.c:33:10fatal error:: '/usr/include/complex.h' file not found
 fatal error: '/usr/include/complex.h' file not found
cxvec.c::33:10:#include "/usr/include/complex.h" 
fatal error: 10'/usr/include/complex.h' file not found:
 #include "/usr/include/complex.h"         ^~~~~~~~~~~~~~~~~~~~~~~~

         ^~~~~~~~~~~~~~~~~~~~~~~~fatal error: '/usr/include/complex.h' file not found

#include "/usr/include/complex.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~
#include "/usr/include/complex.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
1 error generated.
make[2]: *** [cxvec.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [cxvec_math.lo] Error 1

Can't rely in /usr/include existing anymore. Should e.g. #include <complex.h> instead of #include "/usr/include/complex.h".

[michaelld (Michael Dickens)]

Interesting. Yeah no idea why one would #include a precise absolute filename. Relative inside a build maybe, but this? My my my... I'll try building it on my 10.14 buildbot (at work) & fix issues there.

[kencu (Ken)]

perhaps we might reconsider how much we think we still need this patch, as it seems to be our bad here:

<​https://github.com/macports/macports-ports/blob/master/science/libosmo-dsp/files/patch-complex.h.diff>

[kencu (Ken)]

PR submitted. <​https://github.com/macports/macports-ports/pull/3074>>

[ken-cunningham-webuse]

In d05037cc475ff5aeaefb6b483e3a25e727a1f65a/macports-ports (master):

libosmo-dsp: remove old complex.h force

previously was forced to /usr/include to overcome
an old issue with headers that no longer seems
a relevant concern.
closes: #57430