#57433 closed defect (fixed)
paraview: fatal error: 'qvalidator' file not found
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | jjstickel (Jonathan Stickel) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | dstrubbe (David Strubbe) | |
| Port: | paraview |
Description
/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_science_paraview/paraview/work/ParaView-v5.5.2/Qt/ApplicationComponents/pqTransferFunctionWidgetPropertyDialog.cxx:37:10: fatal error: 'qvalidator' file not found
#include <qvalidator>
^~~~~~~~~~~~
1 error generated.
Change History (4)
comment:1 Changed 6 years ago by jjstickel (Jonathan Stickel)
comment:2 follow-up: 4 Changed 5 years ago by ryandesign (Ryan Carsten Schmidt)
As shown by the link in my original report above, this was a build failure from the buildbot, which uses default variants.
Yes, qt5-qtbase contains a file called qvalidator.h, but the #include statement doesn't mention qvalidator.h; it mentions qvalidator, which is not the same file. qt5-qtbase also contains a file called QValidator. On case-insensitive filesystems, #include <qvalidator> would find and use the file QValidator, but that would not happen on case-sensitive filesystems like we use on the buildbot.
The #include should be changed to either #include <QValidator> or #include <qvalidator.h>.
comment:3 Changed 5 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:4 Changed 5 years ago by ryandesign (Ryan Carsten Schmidt)
Replying to ryandesign:
Embarrassingly, we introduced this bug in a patchfile we added for Qt 5 support. I fixed our patchfile.
Why do we have this patchfile? If it fixes a problem, it should be reported to the developers so they can incorporate it into their sources.
Hmm, my first thought was a missing dependency. But qvalidator.h is contained in qt5-qtbase, which is already a dependency, so I don't know. What variants are you using?