gpp4 @1.3.1: libtool: compile: unrecognized option `-pipe'

[ryandesign (Ryan Carsten Schmidt)]

​gpp4 does not build:

mv -f .deps/libgpp4f_la-ccp4_unitcell_f.Tpo .deps/libgpp4f_la-ccp4_unitcell_f.Plo
/bin/sh ../libtool --tag=F77   --mode=compile   -pipe -Os -c -o ccplib.lo ccplib.f
mv -f .deps/libgpp4f_la-ccp4_parser_f.Tpo .deps/libgpp4f_la-ccp4_parser_f.Plo
/bin/sh ../libtool --tag=F77   --mode=compile   -pipe -Os -c -o fftlib.lo fftlib.f
mv -f .deps/libgpp4f_la-ccp4_general_f.Tpo .deps/libgpp4f_la-ccp4_general_f.Plo
/bin/sh ../libtool --tag=F77   --mode=compile   -pipe -Os -c -o modlib.lo modlib.f
libtool: compile: unrecognized option `-pipe'
libtool: compile: Try `libtool --help' for more information.
make[1]: *** [ccplib.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
mv -f .deps/libgpp4f_la-library_f.Tpo .deps/libgpp4f_la-library_f.Plo
libtool: compile: unrecognized option `-pipe'
libtool: compile: Try `libtool --help' for more information.
make[1]: *** [fftlib.lo] Error 1
libtool: compile: unrecognized option `-pipe'
libtool: compile: Try `libtool --help' for more information.
make[1]: *** [modlib.lo] Error 1
2 warnings generated.

[ryandesign (Ryan Carsten Schmidt)]

​This is still happening.

[ryandesign (Ryan Carsten Schmidt)]

The build is erroneously trying to enable the fortran parts when a fortran variant has not been selected.

This is happening because the buildbot does the fetch phase separately (so that failed fetches aren't considered failed builds) but the port erroneously tries to set configure args in the fetch phase. By the time the configure phase is done separately, the args are no longer there. Ports must set configure args either in pre-configure or in the global phaseless part of the portfile.

This problem was introduced in [f81d15d883b637dba04064a72e5d55bc5ecd4b36/macports-ports].

[ryandesign (Ryan Carsten Schmidt)]

In 413c03cd76cab2dd04c87f3a4d950e0932d1cf28/macports-ports (master):

gpp4: Always set configure args, not in fetch phase

Fixes build failure when a fortran variant is not selected and the fetch
phase is run separately from configure (as it is on the buildbot).

See: #57443