Opened 6 years ago

Closed 4 months ago

#57486 closed defect (fixed)

ace, tao @6.5.2: cc1plus: error: unrecognized command line option "-stdlib=libstdc++"

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: lockhart (Thomas Lockhart)
Priority: Normal Milestone:
Component: ports Version:
Keywords: snowleopard Cc: mojca (Mojca Miklavec)
Port: ace, tao

Description

ace and tao @6.5.2 fail to build on Snow Leopard because that OS uses gcc/g++ by default which don't support the -stdlib flag:

cc1plus: error: unrecognized command line option "-stdlib=libstdc++"

If you want to manually add the -stdlib flag as the portfile currently does, you must only do so if ${configure.cxx} contains the string clang.

Instead, you could use ${configure.cxxflags} which will contain the -stdlib flag if the compiler is clang and otherwise will not. I guess this is probably the way we should go.

We should also consider adding ${configure.cflags} where we reinplace @@CFLAGS@@ and adding ${configure.ldflags} where we reinplace @@LDFLAGS@@.

Finally, get_canonical_archflags cc should be get_canonical_archflags cxx since they're replacing @@CXXFLAGS@@.

Sorry, I had made a review of the PR with these comments, but I forgot to submit the review.

Change History (3)

comment:1 Changed 4 years ago by kencu (Ken)

this built recently on 10.6.8 <http://packages.macports.org/ace/ace-6.5.2_1.darwin_10.x86_64.tbz2>

but fails now due to the VERSION file.

That will need a post-extract move to VERSION.txt

comment:2 Changed 4 months ago by jmroot (Joshua Root)

In 60e9a49899840286dbbf4a9e16da1e62dba378de/macports-ports (master):

tao: only use -stdlib when supported

See: #57486

comment:3 Changed 4 months ago by jmroot (Joshua Root)

Resolution: fixed
Status: assignedclosed

In 2304b9dd4657bc0965847e1745e278a41ccacf19/macports-ports (master):

ace: only use -stdlib when supported

Closes: #57486

Note: See TracTickets for help on using tickets.