#57489 closed defect (fixed)
wireshark2 @2.6.4+lua: build fails
| Reported by: | egorenar (Alexander Egorenkov) | Owned by: | ghosthound |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.5.4 |
| Keywords: | Cc: | ||
| Port: | wireshark2 |
Description
wireshark2 port fails if lua variant is activated. with no lua the build succeeds.
Attachments (1)
Change History (9)
Changed 6 years ago by egorenar (Alexander Egorenkov)
comment:1 Changed 6 years ago by Schamschula (Marius Schamschula)
| Keywords: | wireshark2 removed |
|---|---|
| Owner: | set to ghosthound |
| Status: | new → assigned |
comment:2 Changed 6 years ago by ghosthound
| Status: | assigned → accepted |
|---|
comment:3 Changed 6 years ago by ghosthound
comment:4 Changed 6 years ago by kencu (Ken)
You likely have the newer lua @5.3.4_1 installed, and it's trampling the lua52 @5.2.4_1 installation. If you deactivate lua, you should be able to install wireshark2 +lua:
$ port -v installed wireshark2 The following ports are currently installed: wireshark2 @2.6.4_0+cares+geoip+gnutls+kerberos5+libgcrypt+libsmi+lua+portaudio+qt5+zlib (active) platform='darwin 18' archs='x86_64' date='2018-11-05T19:02:54-0800'
To fix this, wireshark2 needs to have the lua-5.2 include directory included AHEAD of the system include directories in it's CMakeLists.txt file. This is a modest PITA to do, but there are plenty of examples in the macports repo of this being done.
wireshark2 is not presently compatible with lua @5.3.4_1, at least with the current versions in MacPorts.
comment:5 Changed 6 years ago by ken-cunningham-webuse
| Resolution: | → fixed |
|---|---|
| Status: | accepted → closed |
comment:6 Changed 6 years ago by ghosthound
While a fix for an issue is always welcome, please do not commit things to ports that are not openmaintainer.
comment:7 Changed 6 years ago by kencu (Ken)
you're right, I should have added "maintainer timeout" to the commit message. Apologies for that.
<https://github.com/macports/macports-ports/pull/2965>
<https://guide.macports.org/chunked/project.update-policies.html>
As you know, it was a trivial fix to a broken variant, otherwise I wouldn't have bothered.
comment:8 Changed 6 years ago by ghosthound
Hmm, never saw the pull notification and can't find it anywhere, not sure why as GitHub should be sending them to me.
Works for me, but I'm not on 10.14 and Xcode 10.1. Presumably there's something different with that combo. The error appears to be:
Can you have a look at that and see if there's a clue there as to what's going on?