libsdl2 @2.0.9: error: property 'CGColor' not found on object of type 'NSColor *'

[ryandesign (Ryan Carsten Schmidt)]

libsdl2 used to build fine on 10.7, and on 10.6 when using the 10.7 sdk, but ​now it fails:

/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_libsdl2/libsdl2/work/SDL2-2.0.9/src/video/cocoa/SDL_cocoawindow.m:1178:53: error: property 'CGColor' not found on object of type 'NSColor *'
    self.layer.backgroundColor = NSColor.blackColor.CGColor;
                                                    ^

[kencu (Ken)]

I sent this one on to Josh a while back.

[kencu (Ken)]

the new libsdl2 has a wonky compatibility version that causes every port I built against libsdl2 to fail to link. Here's a patch that fixes that for me.

[jmroot (Joshua Root)]

Are there upstream bugs for these?

[kencu (Ken)]

not yet. What do you think of them (especially the compatibility fix)?

[jmroot (Joshua Root)]

The 10.7 fix looks fine. I can't reproduce any link failure. We need to point out to upstream that compatibility_version is only supposed to go up and figure out how they want to handle the versioning going forward.

[jmroot (Joshua Root)]

​https://bugzilla.libsdl.org/show_bug.cgi?id=4368
​https://bugzilla.libsdl.org/show_bug.cgi?id=4367

[Schamschula (Marius Schamschula)]

I also ran into the library compatibility issue. I reactivated @2.0.8 until this is fixed.

[jmroot (Joshua Root)]

Can you give specific examples of ports that have a problem with the compatibility version? I tried a couple and they worked OK.

[kencu (Ken)]

there were half a dozen or so.

• libsdl-net
• widelands
• hatari I think
• another libsdl one , maybe image

and a couple more.. More than I wanted to just rebuild, although rebuilding them all would have fixed it I guess.

[Schamschula (Marius Schamschula)]

In my case:

• ffmpeg
• libsdl2_image
• logstalgia

[jmroot (Joshua Root)]

And you're getting an error when you run an executable? Or from rev-upgrade?

[Schamschula (Marius Schamschula)]

I get an error from the link check at the end of port upgrade outdated causing me to have to run rev-upgrade.

On my work machine I also got the error from qt5-qtgamepad.

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #57548.

[rmottola (Riccardo)]

allocate Black constant CGColor directly

[rmottola (Riccardo)]

Sorry for not finding this duplicate ticket earlier, I mistyped the search. I have a quite simple patch which solves CGColor property availabel only in 10.8. Allocating a Black color has a direct function!

[ryandesign (Ryan Carsten Schmidt)]

If you think that's a better fix than the one Ken attached above which Josh ​passed on to the developers, you should notify the developers.

[kencu (Ken)]

Hey, if Riccardo's patch works, I like that better, for sure.

[rmottola (Riccardo)]

Update: with just my "single" one line patch, the port appears to compile and install, I would prefer that to Kencu's.

My only test is running Gimp... and also there could be the other linker errors which I do not address.

I reported upstream on Joshua's patch.

[ryandesign (Ryan Carsten Schmidt)]

Replying to jmroot:

Can you give specific examples of ports that have a problem with the compatibility version? I tried a couple and they worked OK.

All ports that link with libsdl2 should be affected. Selected rev-upgrade output from my system:

Incompatible library version: /opt/local/bin/melt requires version 9.0.0 or later, but /opt/local/lib/libSDL2-2.0.0.dylib provides version 1.0.0
Incompatible library version: /opt/local/lib/mlt/libmltsdl2.dylib requires version 9.0.0 or later, but /opt/local/lib/libSDL2-2.0.0.dylib provides version 1.0.0
Incompatible library version: /opt/local/lib/libSDL2_image-2.0.0.dylib requires version 9.0.0 or later, but /opt/local/lib/libSDL2-2.0.0.dylib provides version 1.0.0
Incompatible library version: /opt/local/bin/plaympeg-smpeg2 requires version 9.0.0 or later, but /opt/local/lib/libSDL2-2.0.0.dylib provides version 1.0.0
Incompatible library version: /opt/local/lib/libsmpeg2-2.0.0.dylib requires version 9.0.0 or later, but /opt/local/lib/libSDL2-2.0.0.dylib provides version 1.0.0
Incompatible library version: /opt/local/lib/libSDL2_mixer-2.0.0.dylib requires version 9.0.0 or later, but /opt/local/lib/libSDL2-2.0.0.dylib provides version 1.0.0
Incompatible library version: /opt/local/bin/gdash requires version 9.0.0 or later, but /opt/local/lib/libSDL2-2.0.0.dylib provides version 1.0.0
Incompatible library version: /opt/local/bin/ffmpeg requires version 9.0.0 or later, but /opt/local/lib/libSDL2-2.0.0.dylib provides version 1.0.0
Incompatible library version: /opt/local/bin/ffplay requires version 9.0.0 or later, but /opt/local/lib/libSDL2-2.0.0.dylib provides version 1.0.0
Incompatible library version: /opt/local/bin/ffprobe requires version 9.0.0 or later, but /opt/local/lib/libSDL2-2.0.0.dylib provides version 1.0.0
Incompatible library version: /opt/local/lib/libavdevice.58.3.100.dylib requires version 9.0.0 or later, but /opt/local/lib/libSDL2-2.0.0.dylib provides version 1.0.0

[kencu (Ken)]

how about we push riccardo's fix and set the compatibility version to 9.0.0? We can come back to it later someday after upstream sorts it out again.

I'll put together a PR. I hate to see so many ports needlessly revbumped.

[jmroot (Joshua Root)]

Replying to ryandesign:

All ports that link with libsdl2 should be affected. Selected rev-upgrade output from my system:

Rev-upgrade detects this, yes. But do you have problems actually running anything? I don't, which is odd. It suggests that rev-upgrade's check may not match what is actually done by dyld, on Mojave at least.

[jmroot (Joshua Root)]

Replying to kencu:

how about we push riccardo's fix and set the compatibility version to 9.0.0? We can come back to it later someday after upstream sorts it out again.

I'll put together a PR. I hate to see so many ports needlessly revbumped.

The problem is, if upstream declines to use the higher version number, I'm not going to fight that forever and the rev bumps won't have been needless.

[l2dy (Zero King)]

Replying to jmroot:

Replying to ryandesign:

All ports that link with libsdl2 should be affected. Selected rev-upgrade output from my system:

Rev-upgrade detects this, yes. But do you have problems actually running anything? I don't, which is odd. It suggests that rev-upgrade's check may not match what is actually done by dyld, on Mojave at least.

I'm on High Sierra and ffmpeg @4.1_0+gpl2 did crash.

dyld: Library not loaded: /opt/local/lib/libSDL2-2.0.0.dylib
  Referenced from: /opt/local/bin/ffmpeg
  Reason: Incompatible library version: ffmpeg requires version 9.0.0 or later, but libSDL2-2.0.0.dylib provides version 1.0.0
Abort trap: 6

[jmroot (Joshua Root)]

The upstream maintainers will be discussing what they want to do with the compatibility version tomorrow.

[jmroot (Joshua Root)]

In 47b164c2bea775b75b40bb2470e492906fd8f315/macports-ports (master):

libsdl2: fix library version, build fix for 10.7

Fixes: #57540